Re: [2.4 patch] netfilter Configure.help cleanup

From: Adrian Bunk (bunk_at_fs.tum.de)
Date: 07/26/03

  • Next message: Duncan Sands: "Re: [2.4.22-pre7] speedtouch.o unresolved symbols"
    Date:	Sat, 26 Jul 2003 12:50:21 +0200
    To: Harald Welte <laforge@netfilter.org>, Rusty Russell <rusty@rustcorp.com.au>, Marcelo Tosatti <marcelo@conectiva.com.br>, "David S. Miller" <davem@redhat.com>, netfilter-devel@lists.netfilter.org, linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
    
    

    On Fri, Jul 25, 2003 at 10:50:24PM +0200, Harald Welte wrote:
    > On Fri, Jul 18, 2003 at 11:06:49AM +1000, Rusty Russell wrote:
    > > In message <20030717201304.GL1407@fs.tum.de> you write:
    > >
    > > > the patch below does the following changes to the netfilter entries in
    > > > Configure.help in 2.4.22-pre2:
    > > > - order similar to net/ipv4/netfilter/Config.in
    > > > - remove useless short descriptions above CONFIG_*
    > > > - added CONFIG_IP_NF_MATCH_RECENT entry (stolen from 2.5)
    > >
    > > Sorry Adrian, I think this is overzealous.
    > >
    > > Please just add the CONFIG_IP_NF_MATCH_RECENT entry. Remember,
    > > "stable" means "boring". 8)
    >
    > I will submit the RECENT entry to davem with my next set of patches.
    >
    > Does everybody else have an ordered Configure.help? if yes, I'd accept

    Most subsytems have their Configure.help entries ordered according to
    the Config.in order.

    > the patch to comply with common practice. If not, I would just say: who
    > cares about the order, it's processed by {old,menu,x}config anyway.

    I'm not religious regarding the order of Configure.help entries, and in
    2.6 this problem will be non-existant.

    cu
    Adrian

    -- 
           "Is there not promise of rain?" Ling Tan asked suddenly out
            of the darkness. There had been need of rain for many days.
           "Only a promise," Lao Er said.
                                           Pearl S. Buck - Dragon Seed
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Duncan Sands: "Re: [2.4.22-pre7] speedtouch.o unresolved symbols"

    Relevant Pages

    • Re: 2.6.13-mm1
      ... > It spat rejects and when I looked at the putative removal date I just ... I can use this to push you harder to forward some patches of me to Linus ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.9-rc3-mm1 build failure
      ... >> produced a build here that actually gets rid of the build error. ... I fixed it up with the below two patches. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [-mm patch] SCSI_QLA2ABC options must select FW_LOADER
      ... > I send a patch for this yesterday that lets SCSI_QLA2XXX select ... stay as it is (with the fixes from my patches) doesn't matter much - ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [linux-dvb-maintainer] [2.6 patch] add missing selects to DVB_BUDGET_AV
      ... > I also added this to linuxtv.org CVS. ... If I were a -stable maintainer, I'd include both patches after they were ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [Lhms-devel] [PATCH 0/7] Fragmentation Avoidance V19
      ... > Sorry this wasn't meant to be a dig at your patches - I guess it turned ... where I went wrong because regression performance is wrong. ... it'll work just fine" fashion. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)