[RFC][PATCH 2.6.0-test2] get rid of unused request_queue field queue_wait

From: Lou Langholtz (ldl_at_aros.net)
Date: 07/28/03

  • Next message: Gerardo Exequiel Pozzi: "[2.6] serial port broken?" 
    Date:	Mon, 28 Jul 2003 02:03:04 -0600
To: linux-kernel <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@suse.de>, Andrew Morton <akpm@digeo.com>

    Are we going to use the queue_wait field of struct request_queue
    someday? As of 2.6.0-test2, I don't see any use of it. If it's not
    needed anymore, the following patch gets rid of it. Tested this patch by
    compiling for i386 and also doing a grep through all .h and .c files to
    see if it's used somewhere else (admittedly weak).

    diff -urN linux-2.6.0-test2/drivers/block/ll_rw_blk.c linux-2.6.0-test2-no_queue_wait/drivers/block/ll_rw_blk.c
    --- linux-2.6.0-test2/drivers/block/ll_rw_blk.c 2003-07-27 19:02:48.000000000 -0600
    +++ linux-2.6.0-test2-no_queue_wait/drivers/block/ll_rw_blk.c 2003-07-27 22:36:16.000000000 -0600
    @@ -225,7 +225,6 @@
              */
             blk_queue_bounce_limit(q, BLK_BOUNCE_HIGH);
     
    - init_waitqueue_head(&q->queue_wait);
             INIT_LIST_HEAD(&q->plug_list);
     }
     
    diff -urN linux-2.6.0-test2/include/linux/blkdev.h linux-2.6.0-test2-no_queue_wait/include/linux/blkdev.h
    --- linux-2.6.0-test2/include/linux/blkdev.h 2003-07-27 19:02:52.000000000 -0600
    +++ linux-2.6.0-test2-no_queue_wait/include/linux/blkdev.h 2003-07-27 22:18:19.000000000 -0600
    @@ -337,8 +337,6 @@
             unsigned long seg_boundary_mask;
             unsigned int dma_alignment;
     
    - wait_queue_head_t queue_wait;
    -
             struct blk_queue_tag *queue_tags;
     
             /*

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Gerardo Exequiel Pozzi: "[2.6] serial port broken?"

    Relevant Pages