[patch 2.6.0-test2: com20020_cs.c doesn't compile

From: Adrian Bunk (bunk_at_fs.tum.de)
Date: 07/28/03

  • Next message: Christoph Hellwig: "Re: [patch 2.6.0-test2: com20020_cs.c doesn't compile"
    Date:	Mon, 28 Jul 2003 15:03:44 +0200
    To: Christoph Hellwig <hch@infradead.org>
    
    

    On Sun, Jul 27, 2003 at 10:08:40AM -0700, Linus Torvalds wrote:
    >...
    > Summary of changes from v2.6.0-test1 to v2.6.0-test2
    > ============================================
    >...
    > Christoph Hellwig:
    >...
    > o [ARCNET]: Fix module refcounting
    >...

    drivers/net/pcmcia/com20020_cs.c wasn't changed, resulting in the
    following compile error:

    <-- snip -->

    ...
      CC drivers/net/pcmcia/com20020_cs.o
    drivers/net/pcmcia/com20020_cs.c: In function `com20020_attach':
    drivers/net/pcmcia/com20020_cs.c:240: error: structure has no member
    named `open_close_ll'
    make[3]: *** [drivers/net/pcmcia/com20020_cs.o] Error 1

    <-- snip -->

    The following patch fixes it:

    --- linux-2.6.0-test2-full-no-smp/drivers/net/pcmcia/com20020_cs.c.tmp 2003-07-28 14:57:35.000000000 +0200
    +++ linux-2.6.0-test2-full-no-smp/drivers/net/pcmcia/com20020_cs.c 2003-07-28 14:58:55.000000000 +0200
    @@ -171,14 +171,6 @@
     
     ======================================================================*/
     
    -static void com20020cs_open_close(struct net_device *dev, bool open)
    -{
    - if (open)
    - MOD_INC_USE_COUNT;
    - else
    - MOD_DEC_USE_COUNT;
    -}
    -
     static dev_link_t *com20020_attach(void)
     {
         client_reg_t client_reg;
    @@ -237,7 +229,7 @@
         lp->backplane = backplane;
         lp->clockp = clockp;
         lp->clockm = clockm & 3;
    - lp->hw.open_close_ll = com20020cs_open_close;
    + lp->hw.owner = THIS_MODULE;
     
         link->irq.Instance = info->dev = dev;
         link->priv = info;

    cu
    Adrian

    -- 
           "Is there not promise of rain?" Ling Tan asked suddenly out
            of the darkness. There had been need of rain for many days.
           "Only a promise," Lao Er said.
                                           Pearl S. Buck - Dragon Seed
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Christoph Hellwig: "Re: [patch 2.6.0-test2: com20020_cs.c doesn't compile"

    Relevant Pages

    • Re: klists and struct device semaphores
      ... > subsys.rwsem because it I think it was supposed to be implementation detail. ... +void device_unlock(struct device * dev) ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] PCI and I2C fixes for 2.6.8
      ... -void pcibios_name_device(struct pci_dev *dev) ... void pcibios_name_device ... static void fixup_windbond_82c105 ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [patch 3/7] Do not register statically allocated input devices
      ... -void input_register_device(struct input_dev *dev) ... struct input_handler *handler; ... void input_unregister_device ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [2.6 patch] fix nfs4xdr.c compile warning
      ... This produces the following compile warning: ... fs/nfsd/nfs4xdr.c:1773: warning: `return' with a value, in function returning void ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH] device-mapper: add dm_get_md
      ... From: David Teigland ... void *dm_get_mdptr(dev_t dev) ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)