Re: Assorted 2.6.0-test2 build warnings

From: Adrian Bunk (bunk_at_fs.tum.de)
Date: 07/29/03

  • Next message: Mikael Pettersson: "RE: PROBLEM: ACPI hangs when invoked from keyboard"
    Date:	Tue, 29 Jul 2003 12:42:10 +0200
    To: "Randy.Dunlap" <rddunlap@osdl.org>
    
    

    On Mon, Jul 28, 2003 at 03:11:04PM -0700, Randy.Dunlap wrote:
    > On Sun, 27 Jul 2003 20:57:31 -0400 "J.C. Wren" <jcwren@jcwren.com> wrote:
    >
    > | Assorted warnings building 2.6.0-test2, on an Athlon:
    > |
    > | CC fs/ntfs/super.o
    > | fs/ntfs/super.c: In function `is_boot_sector_ntfs':
    > | fs/ntfs/super.c:375: warning: integer constant is too large for "long" type
    >
    > Please see if the patch below fixes this one.
    >...
    > ~Randy
    >
    >
    > patch_name: ntfs_ulong.patch
    > patch_version: 2003-07-28.14:29:57
    > author: Randy.Dunlap <rddunlap@osdl.org>
    > description: make a constant be UL;
    > product: Linux
    > product_versions: 2.6.0-test2
    > maintainer: Anton Altaparmakov <aia21@cantab.net>
    > diffstat: =
    > fs/ntfs/layout.h | 2 +-
    > 1 files changed, 1 insertion(+), 1 deletion(-)
    >
    >
    > diff -Naurp ./fs/ntfs/layout.h~type ./fs/ntfs/layout.h
    > --- ./fs/ntfs/layout.h~type 2003-07-27 10:02:48.000000000 -0700
    > +++ ./fs/ntfs/layout.h 2003-07-28 14:05:20.000000000 -0700
    > @@ -43,7 +43,7 @@
    > #define const_cpu_to_le64(x) __constant_cpu_to_le64(x)
    >
    > /* The NTFS oem_id */
    > -#define magicNTFS const_cpu_to_le64(0x202020205346544e) /* "NTFS " */
    > +#define magicNTFS const_cpu_to_le64(0x202020205346544eUL) /* "NTFS " */
    >...

    s/UL/ULL/ (your patch fixed only 64 bit architectures)

    The fix is already in Rusty's trivial patch.

    cu
    Adrian

    -- 
           "Is there not promise of rain?" Ling Tan asked suddenly out
            of the darkness. There had been need of rain for many days.
           "Only a promise," Lao Er said.
                                           Pearl S. Buck - Dragon Seed
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Mikael Pettersson: "RE: PROBLEM: ACPI hangs when invoked from keyboard"

    Relevant Pages

    • Re: 2.6.11-rc2-mm1
      ... > It breaks compilation with gcc-4.0 ... This patch is correct, too. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] i386: always use 4k stacks
      ... reverting my patch would be more ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: RFC: [2.6 patch] better i386 CPU selection
      ... I had a short try to port Debian's patch ... This is not related to the issues my patch addresses. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] update Dag Brattlis email address
      ... > This patch is huge. ... There had been need of rain for many days. ... Pearl S. Buck - Dragon Seed ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [-mm patch] SCSI_QLA2ABC options must select FW_LOADER
      ... > I send a patch for this yesterday that lets SCSI_QLA2XXX select ... stay as it is (with the fixes from my patches) doesn't matter much - ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)