Re: PATCH : LEDs - possibly the most pointless kernel subsystemever

From: Philip Graham Willoughby (pgw99_at_doc.ic.ac.uk)
Date: 07/30/03

  • Next message: Q?=Andrey BorzenkovQ=20?=: "Re: PATCH : LEDs - possibly the most pointless kernel subsystem ever" 
    Date:	Wed, 30 Jul 2003 13:27:49 +0100
To: Ghozlane Toumi <gtoumi@laposte.net>

    On 2003-07-30 14:06:43 +0000, Ghozlane Toumi wrote:
    > > I would have thought that leds are output? Why would output devices be
    > > integrated into the input subsystem?
    >
    > Perhaps because the input subsystem could/should be renamed to event
    > subsytem ?

    The LED devices I'm using are nothing like any of the devices in the
    input subsystem at all -- they don't generate events _ever_ for
    instance. /dev/input/event## for a pure LED device would be rather
    boring.

    IMO it's cleaner to have a LED subsystem and proxy drivers to expose
    LEDs provided by other subsystems to the generic interface, rather than
    trying to ram everything onto the input subsystem regardless of how well
    it fits.

    Of course, other opinions may (will) differ ;-).

    If you did want to get the LED change events from the LED subsystem
    through the input layer, you could add a hook into led_set_real in
    leds.c, but since all changes are software triggered I don't really see
    the value in that.

    Regards,

    Philip Willoughby

    Systems Programmer, Department of Computing, Imperial College, London, UK 

    -- 
echo bzidd@nfo.ho.co.se | tr "bizndfohces" "pwgd9ociaku"
Why reinvent the wheel?                 Because we can make it rounder...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Q?=Andrey BorzenkovQ=20?=: "Re: PATCH : LEDs - possibly the most pointless kernel subsystem ever"

    Relevant Pages

    • Re: PATCH : LEDs - possibly the most pointless kernel subsystem ever
      ... Why would output devices be ... > integrated into the input subsystem? ... Most keyboards have leds, some of them even "new mail" led, and input already handles those. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: PATCH : LEDs - possibly the most pointless kernel subsystemever
      ... >> Better question is why it is not integrated with input subsystem ... (similar to kbd leds). ... Why would output devices be ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] fujtisu application panel driver
      ... The original driver used ioctl's and a separate ... LEDs shoud use the generic led subsystem instead of input layer. ... input subsystem, and no application support for mail led through LED ... No, this drivers mapping table is from bits to key codes, not scan codes to keycodes. ...
      (Linux-Kernel)
    • Re: [PATCH] input: extend EV_LED
      ... But he could export two leds :-). ... | LED device property, this should be exported as a device ... Does it mean that neither the input subsystem nor the led ... subsystem is designed for hardware acelerated blinking leds? ...
      (Linux-Kernel)
    • Re: PATCH : LEDs - possibly the most pointless kernel subsystem ever
      ... > Better question is why it is not integrated with input subsystem (similar to kbd leds). ... Why would output devices be ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)