Re: Warn about taskfile?
From: Pavel Machek (pavel_at_suse.cz)
Date: 07/31/03
- Previous message: Daniel Blueman: "[2.4.22-pre9] Unexpected IO-APIC (works)..."
- In reply to: Bartlomiej Zolnierkiewicz: "Re: Warn about taskfile?"
- Next in thread: Andre Hedrick: "Re: Warn about taskfile?"
- Reply: Andre Hedrick: "Re: Warn about taskfile?"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Thu, 31 Jul 2003 12:28:28 +0200 To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Hi!
> > > > I had some strange fs corruption, and andi suggested that it probably
> > > > is TASKFILE-related. Perhaps this is good idea?
> > >
> > > Idea is good.
> > >
> > > Did corruption go away after disabling taskfile?
> >
> > Not sure, it took week for corruption to creep in, and it might have
> > been loop-related or swsusp-related. I'm not at all sure it was
> > TASKFILE, but I'm turning it off for now.
>
> I doubt it was taskfile, your /dev/hda is using UDMA so taskfile's impact
> is minimal. I've checked this codepath once again today and can't
> see anything which has (possibly) caused Andi's problems.
>
> I think if it is taskfile related it might be caused by some timing issues
> (races) and should be visible (less frequently) with non-taskfile code too
> and this is not happening.
>
> If you are not sure if it was taskfile why do you want to warn about it?
> [ Because Andi is spreading FUD about taskfile? ;-) ]
This was i386 machine, but I'm not sure if I told that to Andi.
> > At least it is strange to have option that says both "experimental"
> > and "it is safe to say Y". What are those "most cases"?
>
> Using (U)DMA should be 100% safe, using single-sector PIO should
> also be safe, using multi-sector PIO might be less safe...
Perhaps this is good idea?
Pavel
--- clean/drivers/ide/Kconfig 2003-07-27 22:31:13.000000000 +0200
+++ linux/drivers/ide/Kconfig 2003-07-31 12:24:16.000000000 +0200
@@ -283,7 +283,8 @@
---help---
Use new taskfile IO code.
- It is safe to say Y to this question, in most cases.
+ It is safe to say Y to this question if you are using (U)DMA or
+ single-sector PIO. Be carefull wilh multi-sector PIO.
comment "IDE chipset support/bugfixes"
depends on BLK_DEV_IDE
-- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Daniel Blueman: "[2.4.22-pre9] Unexpected IO-APIC (works)..."
- In reply to: Bartlomiej Zolnierkiewicz: "Re: Warn about taskfile?"
- Next in thread: Andre Hedrick: "Re: Warn about taskfile?"
- Reply: Andre Hedrick: "Re: Warn about taskfile?"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
