Re: Update MSI Patches

From: Zwane Mwaikambo (zwane_at_linuxpower.ca)
Date: 08/15/03

  • Next message: Greg KH: "[BK PATCH] i2c driver fixes for 2.6.0-test3" 
    Date:	Fri, 15 Aug 2003 14:37:31 -0400 (EDT)
To: long <tlnguyen@snoqualmie.dp.intel.com>

    Ok i tested it on the following configurations;

    UP i8259 w/ CONFIG_PCI_USE_VECTOR is ok
    UP IOAPIC/MP1.4 w/ or w/o CONFIG_PCI_USE_VECTOR is ok
    UP IOAPIC/ACPI w/ or w/o CONFIG_PCI_USE_VECTOR is ok
    8x SMP/MP1.4 w/ or w/o CONFIG_PCI_USE_VECTOR is ok
    8x SMP/ACPI w/ or w/o CONFIG_PCI_USE_VECTOR is ok

    I also just looked again and it does look like the additional interrupt
    controller startup/ack/mask etc member functions are too much duplicated
    code (even if it wont all be in the final image). Perhaps just keep them
    like this;

    static unsigned int startup_edge_ioapic(unsigned int index)
    {
            int irq = vector_to_irq(index);
            ...

            if (platform_legacy_irq(irq)) {
                    ...
            }

            ...
            return
    }

    Also there is a warning whilst compiling which looks like it must be
    fixed.

    Index: linux-2.6.0-test3-msi/arch/i386/kernel/mpparse.c
    ===================================================================
    RCS file: /build/cvsroot/linux-2.6.0-test3/arch/i386/kernel/mpparse.c,v
    retrieving revision 1.2
    diff -u -p -B -r1.2 mpparse.c
    --- linux-2.6.0-test3-msi/arch/i386/kernel/mpparse.c 15 Aug 2003 07:38:39 -0000 1.2
    +++ linux-2.6.0-test3-msi/arch/i386/kernel/mpparse.c 15 Aug 2003 08:02:28 -0000
    @@ -1133,11 +1133,12 @@ void __init mp_parse_prt (void)
     
                     mp_ioapic_routing[ioapic].pin_programmed[idx] |= (1<<bit);
     
    - if (!io_apic_set_pci_routing(ioapic, ioapic_pin, irq))
    + if (!io_apic_set_pci_routing(ioapic, ioapic_pin, irq)) {
                             if (use_pci_vector() && !platform_legacy_irq(irq))
                                     entry->irq = IO_APIC_VECTOR(irq);
                             else
                                     entry->irq = irq;
    + }
     
                     printk(KERN_DEBUG "%02x:%02x:%02x[%c] -> %d-%d -> IRQ %d\n",
                             entry->id.segment, entry->id.bus,
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Greg KH: "[BK PATCH] i2c driver fixes for 2.6.0-test3"

    Relevant Pages