RE: Update MSI Patches
From: Nguyen, Tom L (tom.l.nguyen_at_intel.com)
Date: 08/18/03
- Previous message: Matt Mackall: "Re: Debug: sleeping function called from invalid context"
- Maybe in reply to: long: "Update MSI Patches"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Mon, 18 Aug 2003 14:24:25 -0700 To: "Zwane Mwaikambo" <zwane@linuxpower.ca>
On Mon, 18 Aug 2003, Zwane Mwaikambo wrote:
>> I make minor modification to the last patch to reduce some duplicate functions,
>> as shown as below. I think this perhaps looks better. What do you think?
> The patch looks fine.
>> +#ifdef CONFIG_PCI_USE_VECTOR
>> +static unsigned int startup_edge_ioapic_vector(unsigned int vector)
>> +{
>> + int irq = vector_to_irq(vector);
>> +
>> + return (startup_edge_ioapic_irq(irq));
>> +}
> Tiny nit, Linux coding style is;
> return startup_edge_ioapic_irq(irq);
> But you can queue that change for later.
Good! Thank you for your comments. I will roll your comment on Linux coding style
for later release.
Thanks,
Long
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Matt Mackall: "Re: Debug: sleeping function called from invalid context"
- Maybe in reply to: long: "Update MSI Patches"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
