Re: [PATCH] RFC: kills consistent_dma_mask

From: Jes Sorensen (jes_at_wildopensource.com)
Date: 08/19/03

  • Next message: Alan Cox: "Re: [OT] 'the the' in mails ..."
    To: Alan Cox <alan@lxorguk.ukuu.org.uk>
    Date:	19 Aug 2003 09:20:34 -0400
    
    

    >>>>> "Alan" == Alan Cox <alan@lxorguk.ukuu.org.uk> writes:

    Alan> On Maw, 2003-08-19 at 10:03, Jes Sorensen wrote:
    >> That would be totally messy. Having drivers do the accounting of
    >> what mask is currently set and have them switch back and forth
    >> depending on what type of allocation is currently being used would
    >> be a nightmare to debug.

    Alan> It is messy, but the consistent mask only helps a small subset
    Alan> of cases. Having an __pci_alloc_foo that took the mask as an
    Alan> argument is (a) trivial (b) adds almost no code (c) solves the
    Alan> general case problem.

    And d) puts the accounting back into the drivers in duplicate. So far
    we have managed pretty well with the distinction between consistent
    and dynamic, but sure if there is hardware out there where it makes
    sense to have a more generic interface we should consider it.

    Jes

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Alan Cox: "Re: [OT] 'the the' in mails ..."

    Relevant Pages

    • Re: Another OA Reflector
      ... >> Clear skies, Alan ... I haven't done this experiment with the Moon, but one year I made a 6" mask ... Saturn and Jupiter with and without the mask. ...
      (sci.astro.amateur)
    • Re: [PATCH] avoid endless loops in lib/swiotlb.c
      ... if max_slots is zero (possible if mask is ~0UL) ... max_slots can not be zero. ... You mean no current, in-tree drivers do this, and you imply the code ... requesting e.g. a transfer of 128k with a segment ...
      (Linux-Kernel)
    • Re: [RFC/PATCH] remove unneeded check in bcm43xx
      ... up our DMA mappings internals. ... can't that driver work in PIO only mode? ... _that_ makes sense in fact to have ppc do that when the mask is too ... no clear answer here as some drivers will get highmem pages for DMA, ...
      (Linux-Kernel)
    • Re: The cover of 52#52
      ... traditionally, Alan Scott's mask covers his nose, not just his eyes. ...
      (rec.arts.comics.dc.universe)
    • Re: [PATCH 0/3] Add API for weak DMA masks
      ... specific mask values to check afterwards. ... I could live with having dma_set_mask as an API that fails on bad masks ... Drivers can be migrated over time to the new API (or not. ...
      (Linux-Kernel)