Re: [PATCH] check_gcc for i386

From: Marcelo Tosatti (marcelo_at_parcelfarce.linux.theplanet.co.uk)
Date: 08/31/03

  • Next message: Felipe W Damasio: "[PATCH] Fix SMP support on 3c527 net driver"
    Date:	Sun, 31 Aug 2003 00:03:52 -0300 (BRT)
    To: Jeff Garzik <jgarzik@pobox.com>
    
    

    On Sat, 30 Aug 2003, Jeff Garzik wrote:

    > Alan Cox wrote:
    > > On Sad, 2003-08-30 at 23:58, Marcelo Tosatti wrote:
    > >
    > >>> ifdef CONFIG_MPENTIUM4
    > >>>-CFLAGS += -march=i686
    > >>>+CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
    > >>> endif
    > >>>
    > >>> ifdef CONFIG_MK6
    > >>
    > >>OK, I forgot what that does. Can you please explain in detail what
    > >>check_gcc does.
    > >
    > >
    > > Tries to use gcc with the options given and if not falls back to the
    > > second set suggested. So it'll try -march=pentium4 (new gcc) and
    > > fall back to -march=i686
    >
    >
    > Yep. I introduced check_gcc into 2.4 (backported from 2.5), in fact.
    >
    > The above change does exactly what Alan describes, and is a patch I was
    > planning to submit myself :) I did not want to change compiler options
    > at the time when I submitted the check_gcc patch, but after many months
    > of manually patching to get the best compiler flags, it seems solid.

    I'm just worried about having nicey gcc surprises. Alan thinks its ok, and
    you too so I guess I'll just apply it tomorrow and see what happens

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Felipe W Damasio: "[PATCH] Fix SMP support on 3c527 net driver"

    Relevant Pages

    • Re: [PATCH 12/39] NLKD/i386 - time adjustment
      ... The patch includes code that seems to imply that gcc can not do mpy of variables. ... I really do not see the relavence of the run time library patches given the above. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [CFT] updated gcc-3.4.0 fixes patch for 2.4.27-pre1
      ... I propose fixing problems that will appear with gcc 3.5, ... Here is a patch for the few places I got hit at. ... pci_set_drvdata(pci_dev, dev); ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH 1/2] new valid_signal function (fwd)
      ... A while back I attempted to fix a little, not at all critical, gcc -W ... Below is the first patch that adds the new function. ... pointless and generates warnings when building with gcc -W. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [patch] Re: Kernels > 2.6.1-mm3 do not boot. - REALLY SOLVED
      ... My version of gcc, I just sent you adding the ... >> secondary kernel, recompiled without it and all was fine again. ... This patch should fix it. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [patch] Re: Kernels > 2.6.1-mm3 do not boot. - SOLVED
      ... Later I'll try with more recents releases, ... the patch has solved this issue:) ... +# Check the gcc version since -funit-at-a-time is available since gcc 3.4, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)