questions about fb_pan_display ioctl

• Previous message: Zwane Mwaikambo: "Re: 2.6.0-test4-mm4"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Date:	Sat, 30 Aug 2003 13:02:47 -0400
To: linux-fbdev-devel@lists.sourceforge.net

I was looking through the source, and am mightily confused as to how this
works.

1. The FBIOPAN_DISPLAY ioctl does not error-check var.
2. fb_pan_display uses info->var to bounds-check var->?offset.
3. fb_pan_display modifies info->var, but var is what is returned by the ioctl.
4. The function pointer info->fbops->fb_pan_display takes its args in the opposite
   order to fb_pan_display! Who came up with this?
5. vesafb_pan_display uses var to bounds-check var->?offset, which is
   (a) pointless, since fb_pan_display has bounds-checked it already.
   (b) buggy, since var has never been error-checked, so var->yres could be anything.
6. How does wrapping work, when fb_pan_display has already made sure that yoffset
   cannot cause display to go beyond yres_virtual? The checks in vesafb_pan_display
   do this only when ywrap is disabled, but fb_pan_display always does it.
7. vesafb never uses more than 16mb of video ram, so wrapping can _never_ happen on
   boards with more than 16mb of ram, no?

All these comments refer to 2.6.0-test4. Point 6 should apply to all the fb devices,
not just vesafb.

In 2.4.22, there is no fb_pan_display, but vesafb_pan_display is the same, so it
turns out that wrapping is allowed, but subject to the issues in 5(b) and 7. The issue
in 7 is actually worse, because unless the vram option is passed, the video size is
computed from the mode resolution, so it has nothing to do with the actual amount of
accessible video memory.

-- arvind
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Previous message: Zwane Mwaikambo: "Re: 2.6.0-test4-mm4"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Relevant Pages

• Re: to diminish the time of delay
  ... You would need to use a Windows Media Server, which you should be able to ...
  I use following script to synchronize the video with slide show and to ... var VDState
  = 0 ... .asf video/x-ms-asf ... (microsoft.public.windowsmedia)
• Re: to diminish the time of delay
  ... I use following script to synchronize the video with slide show and to ... var
  VDState = 0 ... ..asf video/x-ms-asf ... If mms:// is pointing to an IIS or
  Apache server, ... (microsoft.public.windowsmedia)
• Re: This small piece of code works in Firefox but not in IE 7... why?
  ... How hard could it be to create the embeded youtube object in ... this is the
  embebed youtube video object: ... var object1 = document.createElement; ...
  Why IE7 gives me an error but Firefox not? ... (comp.lang.javascript)
• Re: Send Video to Html page??
  ... >I have a video on a webpage, where once the video is done playing, I want the ...
  and you can add a "Script Command" at the end ... your video, and in the javascript, set
  var redirURL='newtest.html'; ... function setPlayerID() { ... (microsoft.public.windowsmedia.encoder)
• Re: adding onkeyup to input field
  ... ok I hope I got it not wrapping, because I really do appreciate the ... // makes
  an input field that submits itself using ... var value = el.innerHTML; ...
  (comp.lang.javascript)