Re: [PATCH] OProfile: correct CPU type for x86-64

From: Andi Kleen (ak_at_suse.de)
Date: 08/31/03

  • Next message: Eric W. Biederman: "Re: [Ext2-devel] Re: [RFC] extents support for EXT3"
    To: John Levon <levon@movementarian.org>
    Date:	31 Aug 2003 22:25:08 +0200
    
    

    John Levon <levon@movementarian.org> writes:

    > + break;
    > +#if defined(CONFIG_X86_64)
    > + case 0xf:
    > + model = &op_athlon_spec;
    > + nmi_ops.cpu_type = "x86-64/hammer";
    > + break;
    > +#endif /* CONFIG_X86_64 */

    The ifdef is not needed. The case is valid for i386 too, when running
    an Opteron with an 32bit kernel. In that case you also want the user tools
    to select the Opteron events.

    -Andi

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Eric W. Biederman: "Re: [Ext2-devel] Re: [RFC] extents support for EXT3"

    Relevant Pages

    • Re: Cannot compile without sysctl (+semi-patch)
      ... you should also tell us which kernel version you observed this problem ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • RE: [PATCH] gdth update
      ... pt_regs *regs); ... > the C compiler not of the kernel. ... > ifdef here.... ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.0-test9-mm4 (only) and vmware
      ... > which kernel has this feature is not completed yet. ... As far as fixing the warning, the #ifdef is still needed. ... I'm going to ruminate on non-fatal methods of complaining loudly. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [2.6 patch] cris: remove kernel 2.0 #ifdefs (fwd)
      ... The trivial patch forwarded below still applies against 2.6.10-rc2-mm4. ... Subject: cris: remove kernel 2.0 #ifdef's ... #ifdef CONFIG_PROC_FS ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] [2.4] forcedeth network driver
      ... an ifdef or "if " around. ... this breaks MAC address uniqueness. ... but it doesn't have to be implemented in the kernel. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)