Re: [patch] 2.6.0-test5: serio config broken?

From: Tom Rini (trini_at_kernel.crashing.org)
Date: 09/10/03

  • Next message: Pavel Machek: "Re: BugReport: USB (ACPI), E100, SWSUSP problems (test5 vs. test3)" 
    Date:	Wed, 10 Sep 2003 12:31:58 -0700
To: Adrian Bunk <bunk@fs.tum.de>

    On Wed, Sep 10, 2003 at 09:10:39PM +0200, Adrian Bunk wrote:
    > On Wed, Sep 10, 2003 at 11:59:02AM -0700, Tom Rini wrote:
    > > >
    > > > That wouldn't be needed. AFAIK there are _no_ problems if SERIO=y, the
    > > > select you suggest is already implemented the other way round.
    > >
    > > The problem is that SERIO==y means that SERIO_I8042 must be Y, as you
    > > ran into. If you have SERIO only asked on EMBEDDED || !X86, and on
    > > similar conditions you then select SERIO_I8042, it just works.
    >
    > No the problems occur when SERIO=m.

    Ah, right, that got fixed for test4. Now I recall, I think.

    > > > If SERIO is always y if !EMBEDDED || X86 my patch wouldn't be needed.
    > >
    > > Correct. I was suggesting that you do:
    > > tristate "Serial i/o support (needed for keyboard and mouse)" if
    > > !EMBEDDED || !X86 (or so)
    > > select SERIO_I8042 if X86 && !EMBEDDED
    > >
    > > and then remove the conditions on SERIO_I8042, which puts all of the
    > > auto-select-this magic in one spot.
    >
    > I can't see how this should work in all cases.
    > Could you send how you'd like to formulate this?

    This is done in the patch I sent to break EMBEDDED into STANDARD and
    NONSTD_ABI. There it looks like (just the keyboard bits):
    ===== drivers/input/Kconfig 1.5 vs edited =====
    --- 1.5/drivers/input/Kconfig Wed Jul 16 10:39:32 2003
    +++ edited/drivers/input/Kconfig Fri Sep 5 14:45:36 2003
    @@ -5,7 +5,9 @@
     menu "Input device support"
     
     config INPUT
    - tristate "Input devices (needed for keyboard, mouse, ...)" if EMBEDDED
    + tristate "Input devices (needed for keyboard, mouse, ...)"
    + select INPUT_MOUSEDEV if STANDARD
    + select INPUT_KEYBOARD if STANDARD && X86
             default y
             ---help---
               Say Y here if you have any input device (mouse, keyboard, tablet,
    [snip]
    ===== drivers/input/keyboard/Kconfig 1.6 vs edited =====
    --- 1.6/drivers/input/keyboard/Kconfig Wed Jul 16 10:39:32 2003
    +++ edited/drivers/input/keyboard/Kconfig Fri Sep 5 14:45:36 2003
    @@ -2,8 +2,9 @@
     # Input core configuration
     #
     config INPUT_KEYBOARD
    - bool "Keyboards" if EMBEDDED || !X86
    + bool "Keyboards"
             default y
    + select KEYBOARD_ATKBD if STANDARD && X86
             depends on INPUT
             help
               Say Y here, and a list of supported keyboards will be displayed.
    @@ -12,7 +13,7 @@
               If unsure, say Y.
     
     config KEYBOARD_ATKBD
    - tristate "AT keyboard support" if EMBEDDED || !X86
    + tristate "AT keyboard support"
             default y
             depends on INPUT && INPUT_KEYBOARD && SERIO
             help
    ===== drivers/input/serio/Kconfig 1.9 vs edited =====
    --- 1.9/drivers/input/serio/Kconfig Wed Jul 16 10:39:32 2003
    +++ edited/drivers/input/serio/Kconfig Fri Sep 5 14:45:36 2003
    @@ -2,7 +2,8 @@
     # Input core configuration
     #
     config SERIO
    - tristate "Serial i/o support (needed for keyboard and mouse)"
    + tristate "Serial i/o support (needed for keyboard and mouse)" if !(STANDARD && X86)
    + select SERIO_I8042 if STANDARD && X86
             default y
             ---help---
               Say Yes here if you have any input device that uses serial I/O to
    @@ -19,7 +20,7 @@
               as a module, say M here and read <file:Documentation/modules.txt>.
     
     config SERIO_I8042
    - tristate "i8042 PC Keyboard controller" if EMBEDDED || !X86
    + tristate "i8042 PC Keyboard controller"
             default y
             depends on SERIO
             ---help---

    Where STANDARD is normally Y and NONSTD_ABI is normally N. This groups
    all of the "Well, we're standard so we want a keyboard" logic into 3
    places. Really what could be done is in the question for STANDARD,
    selecting all of the things at once. But I'm not sure if that really
    helps or hurts, so I didn't do it. 

    -- 
Tom Rini
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Pavel Machek: "Re: BugReport: USB (ACPI), E100, SWSUSP problems (test5 vs. test3)"

    Relevant Pages

    • Re: is there a way to run a program independent of the .NET version?
      ... well maybe I was partly wrong and you it should be in the config ... the standard RTFM, "you are an idiot" or just get ignored cause I was the ... the help were just wrong/buggy. ... direction without any tangents to get to the answer. ...
      (microsoft.public.dotnet.framework)
    • Re: SystemACE parts wanted
      ... unless some new silicon solution becomes available: ... so basically you look up the 'standard' connection for the config interface ... and boot media and then design in an Flash FPGA. ... FPGA that is used as the config engine. ...
      (comp.arch.fpga)
    • [PATCH 110/114] x86: move non-standard 32-bit platform Kconfig entries
      ... Choose this option if your computer is a standard PC or compatible. ... bool "Support for ScaleMP vSMP" ... otherwise the kernel you build will not be bootable. ... config SCHED_OMIT_FRAME_POINTER ...
      (Linux-Kernel)
    • Re: Memory mapped IO vs Port IO
      ... can I suggest that we at least ask a standard ... > config WWWW_MMIO ... which can't reliably do MMIO. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Why not XML based configurationfiles?
      ... If you have one standard you don't have to ... Simply using XML does ... use of XML config files. ...
      (comp.os.linux.misc)
    Loading