Re: [CHECKER] 32 Memory Leaks on Error Paths
From: Pete Zaitcev (zaitcev_at_redhat.com)
Date: 09/24/03
- Previous message: Wakko Warner: "Re: Horiffic SPAM"
- In reply to: Alan Cox: "Re: [CHECKER] 32 Memory Leaks on Error Paths"
- Next in thread: Marcelo Tosatti: "Re: [CHECKER] 32 Memory Leaks on Error Paths"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Wed, 24 Sep 2003 12:38:58 -0400 To: Alan Cox <alan@lxorguk.ukuu.org.uk>
> > - spin_lock(&codec->ac97_lock);
> > + down(&unit->ac97_lock);
> > /* XXX Do make use of dev->id */
> > - ymfpci_codec_ready(codec, 0, 0);
>
> This breaks ac97 locking and should not be applied. The core ac97
> code is called some times with interrupts disabled. That is unavoidable.
>
> The only change that is relevant is the kfree
In that case, whoever added spinlocks should have removed
schedule() from ymfpci_ready_wait().
-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Wakko Warner: "Re: Horiffic SPAM"
- In reply to: Alan Cox: "Re: [CHECKER] 32 Memory Leaks on Error Paths"
- Next in thread: Marcelo Tosatti: "Re: [CHECKER] 32 Memory Leaks on Error Paths"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
