Re: [2.6 patch] fix non-modular ftape compile
From: Adrian Bunk (bunk_at_fs.tum.de)
Date: 09/25/03
- Previous message: Andries Brouwer: "Re: rfc: test whether a device has a partition table"
- In reply to: Christoph Hellwig: "Re: [2.6 patch] fix non-modular ftape compile"
- Next in thread: Christoph Hellwig: "Re: [2.6 patch] fix non-modular ftape compile"
- Reply: Christoph Hellwig: "Re: [2.6 patch] fix non-modular ftape compile"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Thu, 25 Sep 2003 13:03:25 +0200 To: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org
On Thu, Sep 25, 2003 at 11:38:16AM +0100, Christoph Hellwig wrote:
> On Thu, Sep 25, 2003 at 12:23:09PM +0200, Adrian Bunk wrote:
> > ftape_proc_destroy is only available #ifdef MODULE, the following patch
> > fixes the link error:
>
> I'd suggest to kill the #ifdef MODULE instead and mark it __exit.
> Same result but less ifdef crap..
It increases the kernel size since in 2.6 __exit functions are discarded
at runtime and not at link time.
Anyway, I agree with your suggestion. The following patch works instead
of the first patch I sent.
--- linux-2.6.0-test5-mm4-no-smp-2.95/drivers/char/ftape/lowlevel/ftape-proc.c.old 2003-09-25 12:46:18.000000000 +0200
+++ linux-2.6.0-test5-mm4-no-smp-2.95/drivers/char/ftape/lowlevel/ftape-proc.c 2003-09-25 12:46:50.000000000 +0200
@@ -207,11 +207,9 @@
ftape_read_proc, NULL) != NULL;
}
-#ifdef MODULE
-void ftape_proc_destroy(void)
+void __exit ftape_proc_destroy(void)
{
remove_proc_entry("ftape", &proc_root);
}
-#endif
#endif /* defined(CONFIG_PROC_FS) && defined(CONFIG_FT_PROC_FS) */
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Andries Brouwer: "Re: rfc: test whether a device has a partition table"
- In reply to: Christoph Hellwig: "Re: [2.6 patch] fix non-modular ftape compile"
- Next in thread: Christoph Hellwig: "Re: [2.6 patch] fix non-modular ftape compile"
- Reply: Christoph Hellwig: "Re: [2.6 patch] fix non-modular ftape compile"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
