Re: RFC: [2.6 patch] disallow modular IPv6

From: Adrian Bunk (bunk_at_fs.tum.de)
Date: 09/29/03

  • Next message: Andries.Brouwer_at_cwi.nl: "[PATCH] befs sparse fixes"
    Date:	Mon, 29 Sep 2003 01:24:03 +0200
    To: Arnaldo Carvalho de Melo <acme@conectiva.com.br>, netdev@oss.sgi.com, davem@redhat.com, pekkas@netcore.fi, lksctp-developers@lists.sourceforge.net, linux-kernel@vger.kernel.org
    
    

    On Sun, Sep 28, 2003 at 08:18:42PM -0300, Arnaldo Carvalho de Melo wrote:
    > Em Mon, Sep 29, 2003 at 12:59:41AM +0200, Adrian Bunk escreveu:
    > > It seems modular IPv6 doesn't work 100% reliable, e.g. after looking at
    > > the code it doesn't seem to be a good idea to compile a kernel without
    > > IPv6 support and later build and install IPv6 modules. Is there a great
    > > need for modular IPv6 or is the patch below to disallow modular IPv6 OK?
    >
    > Please, don't... We're going in the all modules direction, not the other
    > way around, distro (general purpose) kernels would get big bloat in the
    > static kernel.

    E.g. from include/net/tcp.h:

    <-- snip -->

    ...
    struct tcp_skb_cb {
            union {
                    struct inet_skb_parm h4;
    #if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE)
                    struct inet6_skb_parm h6;
    #endif
            } header; /* For incoming frames */
    ...

    <-- snip -->

    This is broken since it's legal to compile a module much later than the
    kernel.

    If modular IPv6 is allowed, the #if has to be removed, and the struct
    will be larger in the case IPv6 is never be used.

    > - Arnaldo

    cu
    Adrian

    -- 
           "Is there not promise of rain?" Ling Tan asked suddenly out
            of the darkness. There had been need of rain for many days.
           "Only a promise," Lao Er said.
                                           Pearl S. Buck - Dragon Seed
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Andries.Brouwer_at_cwi.nl: "[PATCH] befs sparse fixes"

    Relevant Pages

    • Re: IDE-SCSI oops in 2.6.0-test11
      ... | different from the kernel you're running it on. ... Compile your own ... oops as a critical problem. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Distributions
      ... | general there are a lot of packages for people to use. ... kernel, have to run on a multitude of different systems, they tend to be ... and slower than if you compile those packages, ... can have that stability with virtually any distro. ...
      (Debian-User)
    • Re: Distributions
      ... Ubuntu is based on Debian, ... | general there are a lot of packages for people to use. ... kernel, have to run on a multitude of different systems, they tend to be larger ... and slower than if you compile those packages, ...
      (Debian-User)
    • Problems with custom kernel fbsd 6.2
      ... My kernel for freebsd 6.2 is not compiling but only with my custom config. ... I was able to compile it with the GENERIC kernel included, but my modified one will not compile. ... # Power management support ...
      (freebsd-questions)
    • Feedback 2.6.0-test2
      ... to compile the new kernel but it did not function: ... feedback for your kernel. ... Otto-von-Guericke-Universitaet Magdeburg ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)