Re: [PATCH] remove unnecessary #includes from <linux/fs.h>

From: Tim Schmielau (tim_at_physik3.uni-rostock.de)
Date: 10/03/03

  • Next message: Greg Ungerer: "[PATCH]: linux-2.6.0-test6-uc0 (MMU-less fix ups)" 
    Date:	Fri, 3 Oct 2003 17:03:52 +0200 (CEST)
To: Jörn Engel <joern@wohnheim.fh-wedel.de>

    > You didn't comment on my suggestion, so I've done it manually once for
    > linux/fs.h and was shocked. It still passes my compile-standalone
    > test after removing 11! #include lines.

    A compile-standalone test is a necessary condition but not a sufficient
    one. There can be many reasons why the includes might still be needed:
     - the compile-test might depend on the specific configuration.
     - the included header might be needed when the macros are used, not when
       they are defined.
     - indirect includes
     - ...
    As you probably know, I tried to clean up sched.h, and it was extremely
    complicated to get right. So this definitely is 2.7 material.

    Tim

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Greg Ungerer: "[PATCH]: linux-2.6.0-test6-uc0 (MMU-less fix ups)"