Re: [patch] 2.4.23-pre8: link error with both megaraid drivers

From: Adrian Bunk (bunk_at_fs.tum.de)
Date: 10/23/03

  • Next message: Adrian Bunk: "2.4.23-pre8: link error with multiple USB Gadget drivers"
    Date:	Thu, 23 Oct 2003 21:52:24 +0200
    To: Xose Vazquez Perez <xose@wanadoo.es>
    
    

    On Thu, Oct 23, 2003 at 05:27:25PM +0200, Xose Vazquez Perez wrote:
    > Adrian Bunk wrote:
    >
    > > The patch below fixes this issue by disalllowing the static inclusion of
    > > both drivers at the same time.
    >
    > IMO this patch makes a better job. It only allows one in kernel,
    > and it allows two modules at same time.
    >...

    My patch allows this, too, or what did I miss?

    > -thanks-
    >
    > --- linux/drivers/scsi/Config.in 2003-10-23 16:56:13.000000000 +0200
    > +++ new/drivers/scsi/Config.in 2003-10-23 17:00:51.000000000 +0200
    > @@ -66,8 +66,14 @@
    > dep_tristate 'AdvanSys SCSI support' CONFIG_SCSI_ADVANSYS $CONFIG_SCSI
    > dep_tristate 'Always IN2000 SCSI support' CONFIG_SCSI_IN2000 $CONFIG_SCSI
    > dep_tristate 'AM53/79C974 PCI SCSI support' CONFIG_SCSI_AM53C974 $CONFIG_SCSI $CONFIG_PCI
    > -dep_tristate 'AMI MegaRAID support' CONFIG_SCSI_MEGARAID $CONFIG_SCSI
    > -dep_tristate 'AMI MegaRAID2 support' CONFIG_SCSI_MEGARAID2 $CONFIG_SCSI
    > +
    > +if [ "$CONFIG_SCSI_MEGARAID2" != "y" ]; then
    > + dep_tristate 'AMI MegaRAID support' CONFIG_SCSI_MEGARAID $CONFIG_SCSI
    > +fi
    > +
    > +if [ "$CONFIG_SCSI_MEGARAID" != "y" ]; then
    > + dep_tristate 'AMI MegaRAID2 support' CONFIG_SCSI_MEGARAID2 $CONFIG_SCSI
    > +fi
    >
    > dep_tristate 'BusLogic SCSI support' CONFIG_SCSI_BUSLOGIC $CONFIG_SCSI
    > if [ "$CONFIG_SCSI_BUSLOGIC" != "n" ]; then

    The difference between your and my patch is that your patch doesn't
    allow one in kernel plus the other one modular.

    cu
    Adrian

    -- 
           "Is there not promise of rain?" Ling Tan asked suddenly out
            of the darkness. There had been need of rain for many days.
           "Only a promise," Lao Er said.
                                           Pearl S. Buck - Dragon Seed
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Adrian Bunk: "2.4.23-pre8: link error with multiple USB Gadget drivers"

    Relevant Pages

    • Re: 2.6.11-rc2-mm1
      ... > It breaks compilation with gcc-4.0 ... This patch is correct, too. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] i386: always use 4k stacks
      ... reverting my patch would be more ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: RFC: [2.6 patch] better i386 CPU selection
      ... I had a short try to port Debian's patch ... This is not related to the issues my patch addresses. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] update Dag Brattlis email address
      ... > This patch is huge. ... There had been need of rain for many days. ... Pearl S. Buck - Dragon Seed ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [-mm patch] SCSI_QLA2ABC options must select FW_LOADER
      ... > I send a patch for this yesterday that lets SCSI_QLA2XXX select ... stay as it is (with the fixes from my patches) doesn't matter much - ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)