[PATCH] input / keyboard / Scancode Set 3 support broken

From: Knut Petersen (Knut_Petersen_at_t-online.de)
Date: 10/24/03

  • Next message: Pavel Machek: "Re: Wow. Suspend to disk works for me in test8. :)" 
    Date:	Fri, 24 Oct 2003 09:56:33 +0200
To: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>

    Hi everybody!

    If somebody uses keyboard scancode set 3 it is necessary to explicitly
    program the keyboard to send make/break codes for all keys and to set
    autorepeat for all keys. I reported this bug and the suggested fix to
    Vojtech Pavlik almost a month ago and he published the enclosed patch.

    This patch never made it to the main kernel tree, but it is really critical
    for some people. One example is the LK461/46W series of keyboards from Digital
    Equipment Corporations. These are VMS keyboards that are also usable
    on a normal PC.

    These keyboards support Scancode Set 2, but for some keys this support is
    screwed up -- some function keys (e.g. F18/F20) report the same
    scancode sequence combined with both alt and shift keys.

    Scancode Set 3 works perfectly if all keys are programmed to give make/break codes.

    A lot of keyboards manufactured by Cherry only make/break for some (not all!)
    modifyer keys in scancode set 3 without this fix.

    I believe that this patch is nothing but a very obvious bug fix, please
    include it in the linux kernel.

    cu,
     Knut Petersen

    Below find the patch from Vojtech as published on 29-sep-2003:

    ===================================================================

    ChangeSet@1.1385, 2003-09-29 12:59:49+02:00, vojtech@suse.cz
      input: Explicitly set All-Repeat mode in Set3 on AT keyboards.

     atkbd.c | 3 +++
     1 files changed, 3 insertions(+)

    ===================================================================

    diff -Nru a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
    --- a/drivers/input/keyboard/atkbd.c Mon Sep 29 19:36:59 2003
    +++ b/drivers/input/keyboard/atkbd.c Mon Sep 29 19:36:59 2003
    @@ -111,6 +111,7 @@
     #define ATKBD_CMD_SETREP 0x10f3
     #define ATKBD_CMD_ENABLE 0x00f4
     #define ATKBD_CMD_RESET_DIS 0x00f5
    +#define ATKBD_CMD_SETALL_MBR 0x00fa
     #define ATKBD_CMD_RESET_BAT 0x02ff
     #define ATKBD_CMD_RESEND 0x00fe
     #define ATKBD_CMD_EX_ENABLE 0x10ea
    @@ -519,6 +520,8 @@
       if (atkbd_command(atkbd, param, ATKBD_CMD_SSCANSET))
       return 2;
      }
    +
    + atkbd_command(atkbd, param, ATKBD_CMD_SETALL_MBR);
     
      return 3;
     }

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Pavel Machek: "Re: Wow. Suspend to disk works for me in test8. :)"

    Relevant Pages

    • Re: Input issues - key down with no key up
      ... > Won't work on keyboards which send more than one DOWN before an UP. ... >> report UP events, it won't repeat and it will report DOWN then UP ... I meant the keys which started this thread: ... If switching to scancode set 3 solves the whole problem, ...
      (Linux-Kernel)
    • Re: Great SWT Program
      ... the keys standard with those keyboards are; ... I've had occasion to use xfig to make diagrams for inclusion in LaTeX ... Yours I assume includes a command name at least as long as ...
      (comp.lang.java.programmer)
    • Re: Intemittent operation of some keys
      ... Laptop keys are fragile beasties, I don't recommend prying them off ... I have had computer keyboards since 1981 and I learned to type on an old Remington typewriter that you really had to smack the keys to make a good impression on paper. ... Laptop keys are typically closer together. ...
      (comp.sys.laptops)
    • Re: [SLE] Keyboard test
      ... of my keyboards and it had stuck keys for a while. ... what are folks' favorite ways of cleaning keyboards? ... often wash the keyboards under the hot water tap. ... circuit boards may be manufactured with ...
      (SuSE)
    • Re: [opensuse] Re: New desktop
      ... the old IBM keyboards are absolutely the most ... Although I confess being a silent PC geek and there is hardly anything ... This is typed on a Model M style keyboard with 122 keys that I got from ... the Scroll Lock, Print Screen, and Pause keys that I've never seen work on ...
      (SuSE)
    Loading