[PATCH] 2.6.0-test9 Fix oops in quirk_via_bridge

From: Michael Clark (michael_at_metaparadigm.com)
Date: 10/31/03

  • Next message: Christoph Hellwig: "Re: [PATCH] Re: AMD 53c974 SCSI driver in 2.6" 
    Date:	Fri, 31 Oct 2003 17:42:07 +0800
To: greg@kroah.com, linux-kernel@vger.kernel.org

    I have a VIA cardbus 1394 controller which oops on insertion
    after an APM suspend/resume cycle (without card inserted):

    bounds: 0000 [#1]
    CPU: 0
    EIP: 0060:[<c0300060>] Tainted: PF
    EFLAGS: 00010206
    EIP is at quirk_via_bridge+0x4/0x1c
    eax: 0000ffff ebx: c02982e0 ecx: d1958000 edx: 000c0010
    esi: d1958000 edi: 00000001 ebp: 00000000 esp: da401ee8
    ds: 007b es: 007b ss: 0068
    Process pccardd (pid: 1093, threadinfo=da400000 task=da4c8780)
    Stack: c019fb85 d1958000 00000001 d1958000 00000000 c019fbc2 d1958000 00000001
             c02980a0 d1958000 dfdebf14 c019d828 00000001 d1958000 00000000 dec2802c
             dfdebf00 dfdebf14 00000000 e3dfe7c7 dfdebf00 00000000 dec2802c da401f48
    Call Trace:
       [<c019fb85>] pci_do_fixups+0x52/0x54
       [<c019fbc2>] pci_fixup_device+0x3b/0x49
       [<c019d828>] pci_scan_slot+0x46/0x8f
       [<e3dfe7c7>] cb_alloc+0x29/0xf7 [pcmcia_core]
       [<e3dfb9aa>] socket_insert+0x90/0x102 [pcmcia_core]
       [<e3dfbc0d>] socket_detect_change+0x54/0x7e [pcmcia_core]
       [<e3dfbdbc>] pccardd+0x185/0x1f9 [pcmcia_core]

    quirk_via_bridge (which is marked device PCI_ANY_ID) triggers on
    my 1394 controller which vendor=VIA but is not a bridge.

    Strangely making the quirk and its data __devinit solves the problem
    (as is most of the other stuff in pci/quirks.c). Not sure if it is
    the correct fix but it works for me. ie. why did I get the oops
    in the first place? as the quirks data was global and not marked
    for an __init section.

    $ lspci -d 1106:
    07:00.0 FireWire (IEEE 1394): VIA Technologies, Inc. IEEE 1394 Host Controller (rev 46)

    ~mc

    --- linux-2.6.0-test9/drivers/pci/quirks.c 2003-10-31 16:49:25.000000000 +0800
    +++ linux-2.6.0-test9-mc/drivers/pci/quirks.c 2003-10-31 16:49:57.000000000 +0800
    @@ -644,9 +644,9 @@
      * VIA northbridges care about PCI_INTERRUPT_LINE
      */
      
    -int interrupt_line_quirk;
    +__devinitdata int interrupt_line_quirk;
     
    -static void __init quirk_via_bridge(struct pci_dev *pdev)
    +static void __devinit quirk_via_bridge(struct pci_dev *pdev)
     {
             if(pdev->devfn == 0)
                     interrupt_line_quirk = 1;

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Christoph Hellwig: "Re: [PATCH] Re: AMD 53c974 SCSI driver in 2.6"

    Relevant Pages