Re: [PATCH] fix rq->flags use in ide-tape.c

From: Bartlomiej Zolnierkiewicz (B.Zolnierkiewicz_at_elka.pw.edu.pl)
Date: 11/05/03

  • Next message: Arjan van de Ven: "Re: [PATCH] fix rq->flags use in ide-tape.c" 
    To: Jens Axboe <axboe@suse.de>
Date:	Wed, 5 Nov 2003 13:00:47 +0100

    On Wednesday 05 of November 2003 09:40, Jens Axboe wrote:
    > On Tue, Nov 04 2003, Linux Kernel Mailing List wrote:
    > > ChangeSet 1.1413, 2003/11/04 08:01:30-08:00,
    > > B.Zolnierkiewicz@elka.pw.edu.pl
    > >
    > > [PATCH] fix rq->flags use in ide-tape.c
    > >
    > > Noticed by Stuart_Hayes@Dell.com:
    >
    > Guys, this is _way_ ugly. We definitely dont need more crap in ->flags
    > for private driver use, stuff them somewhere else in the rq. rq->cmd[0]
    > usage would be a whole lot better. This patch should never have been
    > merged. If each and every driver needs 5 private bits in ->flags,
    > well...

    Yeah, it is ugly. Using rq->cmd is also ugly as it hides the problem in
    ide-tape.c, but if you prefer this way I can clean it up. I just wanted
    minimal changes to ide-tape.c to make it working.

    > Was this even posted on linux-kernel for review?

    Yes.

    --bartlomiej

    > > @@ -218,6 +223,11 @@
    > > #define REQ_PM_SUSPEND (1 << __REQ_PM_SUSPEND)
    > > #define REQ_PM_RESUME (1 << __REQ_PM_RESUME)
    > > #define REQ_PM_SHUTDOWN (1 << __REQ_PM_SHUTDOWN)
    > > +#define REQ_IDETAPE_PC1 (1 << __REQ_IDETAPE_PC1)
    > > +#define REQ_IDETAPE_PC2 (1 << __REQ_IDETAPE_PC2)
    > > +#define REQ_IDETAPE_READ (1 << __REQ_IDETAPE_READ)
    > > +#define REQ_IDETAPE_WRITE (1 << __REQ_IDETAPE_WRITE)
    > > +#define REQ_IDETAPE_READ_BUFFER (1 << __REQ_IDETAPE_READ_BUFFER)

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Arjan van de Ven: "Re: [PATCH] fix rq->flags use in ide-tape.c"

    Relevant Pages

    • two pipe bugfixes
      ... Current output of strace with this patch applied is this: ... usage with all sort of desktop apps and twisted). ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [RFC] [PATCH 1/3] ioat: DMA subsystem
      ... if you disagree please submit a patch to ... - if it gets accepted fine, else just remove this usage. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] fix rq->flags use in ide-tape.c
      ... On Wed, Nov 05 2003, Bartlomiej Zolnierkiewicz wrote: ... >> usage would be a whole lot better. ... This patch should never have been ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] PCI and PCI Hotplug update for 2.6.6-rc1
      ... >>Yeah well... ... in the intervening time, somebody on IRC commented ... Here's an updated patch, applies to 2.6.5-rc2-bk9. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] add feature-removal-schedule.txt documentation
      ... >> Ok, I'll bite, here's a patch that does just that. ... Heh, yeah right, might as well just add the following also if we are in ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)