Re: [PATCH] fix rq->flags use in ide-tape.c

From: Jens Axboe (axboe_at_suse.de)
Date: 11/05/03

  • Next message: Jens Axboe: "Re: [PATCH] fix rq->flags use in ide-tape.c" 
    Date:	Wed, 5 Nov 2003 13:36:26 +0100
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>

    On Wed, Nov 05 2003, Bartlomiej Zolnierkiewicz wrote:
    > On Wednesday 05 of November 2003 09:40, Jens Axboe wrote:
    > > On Tue, Nov 04 2003, Linux Kernel Mailing List wrote:
    > > > ChangeSet 1.1413, 2003/11/04 08:01:30-08:00,
    > > > B.Zolnierkiewicz@elka.pw.edu.pl
    > > >
    > > > [PATCH] fix rq->flags use in ide-tape.c
    > > >
    > > > Noticed by Stuart_Hayes@Dell.com:
    > >
    > > Guys, this is _way_ ugly. We definitely dont need more crap in ->flags
    > > for private driver use, stuff them somewhere else in the rq. rq->cmd[0]
    > > usage would be a whole lot better. This patch should never have been
    > > merged. If each and every driver needs 5 private bits in ->flags,
    > > well...
    >
    > Yeah, it is ugly. Using rq->cmd is also ugly as it hides the problem in
    > ide-tape.c, but if you prefer this way I can clean it up. I just wanted
    > minimal changes to ide-tape.c to make it working.

    Well using ->cmd is acceptable. Adding these 5 bits for ide-tape is, on
    the other hand, completely and utterly unacceptable. So I'd greatly
    prefer it that way :)

    > > Was this even posted on linux-kernel for review?
    >
    > Yes.

    Ok missed it then. 

    -- 
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Jens Axboe: "Re: [PATCH] fix rq->flags use in ide-tape.c"

    Relevant Pages