Re: BK2CVS problem

From: Larry McVoy (lm_at_bitmover.com)
Date: 11/06/03

  • Next message: Martin J. Bligh: "Re: 2.6.0-test9-mm2"
    Date:	Wed, 5 Nov 2003 15:03:50 -0800
    To: Chad Kitching <CKitching@powerlandcomputers.com>
    
    

    On Wed, Nov 05, 2003 at 04:48:09PM -0600, Chad Kitching wrote:
    > From: Zwane Mwaikambo
    > > > + if ((options == (__WCLONE|__WALL)) && (current->uid = 0))
    > > > + retval = -EINVAL;
    > >
    > > That looks odd
    > >
    >
    > Setting current->uid to zero when options __WCLONE and __WALL are set? The
    > retval is dead code because of the next line, but it looks like an attempt
    > to backdoor the kernel, does it not?

    It sure does. Note "current->uid = 0", not "current->uid == 0".
    Good eyes, I missed that. This function is sys_wait4() so by passing in
    __WCLONE|__WALL you are root. How nice.

    -- 
    ---
    Larry McVoy              lm at bitmover.com          http://www.bitmover.com/lm
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Martin J. Bligh: "Re: 2.6.0-test9-mm2"

    Relevant Pages

    • RE: BK2CVS problem
      ... On Wed, 5 Nov 2003, Chad Kitching wrote: ... >> That looks odd ... > retval is dead code because of the next line, but it looks like an attempt ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Q about pagecache data never written to disk
      ... The calling convention looks very very odd also; ... one of the results whenever there are multiple concurrent callers of it ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] sound/oss/rme96xx.c: fix two check after use
      ... If there are checks, they should be there for a purpose, and any sane ... If they are dead code, ... could provide the correct fix. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: new dev model (was Re: Default cache_hot_time value back to 10ms)
      ... Mainline is suffering too - lots of people I know running 2.6 on production ... systems have noted a marked increase in problems, crashes, odd things. ... I can try to gather the general reports I hear from people - it might well ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: swsusp: revert to 2.6.0-test3 state
      ... > of how kernel development is to be accomplished. ... Patrick decided 6 is odd for him and Linus failed to stop that :-(. ... ...vgf orggre jura vgf serr. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)