Re: [patch] reproducible athlon mce fix

From: Geoffrey Lee (glee_at_gnupilgrims.org)
Date: 11/03/03

  • Next message: Geoffrey Lee: "Re: [patch] reproducible athlon mce fix" 
    Date:	Mon, 3 Nov 2003 17:20:48 +0800
To: Dave Jones <davej@redhat.com>, linux-kernel@vger.kernel.org

    On Sun, Nov 02, 2003 at 12:52:03PM +0000, Dave Jones wrote:
    > On Sun, Nov 02, 2003 at 01:57:48PM +0800, Geoffrey Lee wrote:
    >
    > > preempt_disable();
    > > +#if CONFIG_MK7
    > > + for (i=1; i<nr_mce_banks; i++) {
    > > +#else
    > > for (i=0; i<nr_mce_banks; i++) {
    > > +#endif
    > > rdmsr (MSR_IA32_MC0_STATUS+i*4, low, high);
    >
    > This needs to be a runtime check. In 2.6, a K7 can boot
    > a P4 kernel, and vice versa.
    >

    (Resending as it seems to have eaten my mail due to dns problems ... apologies
    if you get this twice.)

    Would checking boot_cpu_data.x86_vendor == X86_VENDOR_AMD and
    boot_cpu_data.x86 == 6 be sufficient? It seems to do the right thing ..
    Updated patch attached.

            - g.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Geoffrey Lee: "Re: [patch] reproducible athlon mce fix"

    Relevant Pages