Re: Bug (?) in subsystem kset refcounts

From: Greg KH (greg_at_kroah.com)
Date: 11/09/03

  • Next message: Greg KH: "Re: Accessing device information in REMOVE agent"
    Date:	Sun, 9 Nov 2003 11:42:11 -0800
    To: Alan Stern <stern@rowland.harvard.edu>
    
    

    On Sun, Nov 09, 2003 at 12:01:41PM -0500, Alan Stern wrote:
    > It's unfortunate that initialization of various parts of a kobject or
    > driver-model object is so order-sensitive. Worse yet is the fact that
    > these dependencies are not mentioned in Documentation/kobject.txt,
    > Documentation/driver-model, include/linux/kobject.h, or
    > include/linux/device.h. Wouldn't it be a good idea to add, for example to
    > Documentation/kobject.txt, a description of which members of struct
    > kobject must be initialized before calling kobject_init() and which must
    > be initialized before calling kobject_add()? And of course to do the same
    > for all the other important structures as well.

    I agree. More documentation is definitely needed. I know Pat has some
    documentation changes queued up, but patches to update portions that are
    missing (such as these requirements) will always be gladly accepted.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Greg KH: "Re: Accessing device information in REMOVE agent"

    Relevant Pages

    • Re: Bug (?) in subsystem kset refcounts
      ... > Also, notice that when the kobject is initialized, the kset set by these ... It's unfortunate that initialization of various parts of a kobject or ... kobject must be initialized before calling kobject_initand which must ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.25-rc1-sha1: WARNING: at lib/kref.c:43 kref_get+0x20/0x30()
      ... miss to initialization of a kobject when sysfs is not compiled in. ... seems the "notes" directory should not be created if SYSFS is not ... static inline void add_sect_attrs(struct module *mod, unsigned int nsect, ...
      (Linux-Kernel)
    • Re: 2.6.25-rc1-sha1: WARNING: at lib/kref.c:43 kref_get+0x20/0x30()
      ... miss to initialization of a kobject when sysfs is not compiled in. ... seems the "notes" directory should not be created if SYSFS is not ... Idea was good and below is patch which compiles and works. ...
      (Linux-Kernel)
    • Re: BUG: ps2esdi causes kobject badness + OOPS
      ... That line means that this kobject was not initialized before we tried to ... due to the MCA initialization code somehow:) ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: Current saa7134 driver breaks KNC One Tv-Station DVR (card=24)
      ... > dependent modules because this module is not initialized yet (what if ... > initialization?). ... the whole boot process hangs. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)