cleanups for input

From: Pavel Machek (pavel_at_ucw.cz)
Date: 11/16/03

  • Next message: Pavel Machek: "Corrected drivermodel for i8042.c" 
    Date:	Sun, 16 Nov 2003 14:09:09 +0100
To: vojtech@ucw.cz, kernel list <linux-kernel@vger.kernel.org>, Rusty trivial patch monkey Russell <trivial@rustcorp.com.au>

    Hi!

    I know cleanups are not wanted just now, but I'd like this queued...

    GFP_ATOMIC can fail at any time; I believe we do not want "heisenbugs"
    so we should at least warn.

    [serio_rescan() does not return error value yet it can fail. It seems
    pretty broken to me :-(.]

    --- tmp/linux/drivers/input/serio/serio.c 2003-09-28 22:05:48.000000000 +0200
    +++ linux/drivers/input/serio/serio.c 2003-11-15 20:41:24.000000000 +0100
    @@ -134,8 +134,10 @@
     {
             struct serio_event *event;
     
    - if (!(event = kmalloc(sizeof(struct serio_event), GFP_ATOMIC)))
    + if (!(event = kmalloc(sizeof(struct serio_event), GFP_ATOMIC))) {
    + printk(KERN_CRIT "Could not rescan serio: out of memory\n");
                     return;
    + }
     
             event->type = SERIO_RESCAN;
             event->serio = serio; 

    -- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Pavel Machek: "Corrected drivermodel for i8042.c"

    Relevant Pages