Re: [PATCH] fix use-after-free in sbp2.c

From: Ben Collins (bcollins_at_debian.org)
Date: 12/03/03

  • Next message: Jeff Garzik: "Re: libata in 2.4.24?"
    Date:	Tue, 2 Dec 2003 18:31:25 -0500
    To: Martin Waitz <tali@admingilde.org>
    
    

    On Mon, Dec 01, 2003 at 10:02:12PM +0100, Martin Waitz wrote:
    > hi :)
    >
    > when using some checking code (CONFIG_DEBUG_{SLAB,SPINLOCK_SLEEP},
    > sbp2 fails to log in into my external hd enclosure.
    >
    > that is because sbp2_agent_reset sends a packet and waits
    > for its delivery.
    > however, the function used to create the packet activates
    > auto-destruct of the packet via hpsb_set_packet_complete_task.
    > thus, the semaphore used for synchronization is destroyed
    > while the sending task is waiting.
    >
    > the following patch (against -test11) fixes sbp2 for me

    Could you test what's in our repo first? We've already fixed this, but
    it was done in a way different way than you did (we got rid of the
    semaphore).

    -- 
    Debian     - http://www.debian.org/
    Linux 1394 - http://www.linux1394.org/
    Subversion - http://subversion.tigris.org/
    WatchGuard - http://www.watchguard.com/
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Jeff Garzik: "Re: libata in 2.4.24?"

    Relevant Pages

    • Re: Application, dll and driver design
      ... How big can semaphore "lMaximumCount" can be. ... > But there is one problem with replacing window messages with packet reading ... I have 15 processes all talking to each other and Dll process. ...
      (microsoft.public.win32.programmer.ui)
    • Re: [patch] update: _working_ code to add device+inode check to ipt_owner.c
      ... The xinetd server will see the initial ... packet, then fork/exec and close off all extra fds. ... level is before sock lookup. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Linux-2.6.12
      ... a procedure that has taken a semaphore can't ... kernel BUG at mm/memory.c:1112! ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Entirely ignoring TCP and UDP checksum in kernel level
      ... > into the issue and fount out that; ... So if we took any packet that came in from 192.168.1.1 and substituted 192.178.77.1 for the Source ... address and then re-calculated the IP checksum you would be up and running? ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [RFC/RFT] Better handling of bad xfers/interrupt delays in psmouse
      ... >> The patch below attempts to better handle situation when psmouse interrupt ... >> properly synchronize with the beginning of the packet as mouse is supposed ... > I'd suspect it could just resend the last byte. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)

    Loading