Re: 2.4.23-bk bogus edd changeset - Re: 2.4.23 compile error in edd

From: Matt Domsch (Matt_Domsch_at_dell.com)
Date: 12/05/03

  • Next message: Martin J. Bligh: "2.6.0-test11-mjb1" 
    Date:	Fri, 5 Dec 2003 11:36:19 -0600
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>

    > On Thu, 4 Dec 2003, Anton Altaparmakov wrote:
    > > 2.4.23-bk has a changeset (post 2.4.23 release TAG) that makes edd not
    > > compile as Meelis Roos already reported:
    > > > DISKSIG_BUFFER is nowhere to be seen.

    Yeah, that's my bad, setup.c should say DISK80_SIG_BUFFER not
    DISKSIG_BUFFER.

    ===== arch/i386/kernel/setup.c 1.77 vs edited =====
    --- 1.77/arch/i386/kernel/setup.c Mon Dec 1 09:23:55 2003
    +++ edited/arch/i386/kernel/setup.c Fri Dec 5 10:58:11 2003
    @@ -211,7 +211,7 @@
     #define KERNEL_START (*(unsigned long *) (PARAM+0x214))
     #define INITRD_START (*(unsigned long *) (PARAM+0x218))
     #define INITRD_SIZE (*(unsigned long *) (PARAM+0x21c))
    -#define DISK80_SIGNATURE_BUFFER (*(unsigned int*)(PARAM+DISKSIG_BUFFER))
    +#define DISK80_SIGNATURE_BUFFER (*(unsigned int*)(PARAM+DISK80_SIG_BUFFER))
     #define EDD_NR (*(unsigned char *) (PARAM+EDDNR))
     #define EDD_BUF ((struct edd_info *) (PARAM+EDDBUF))
     #define COMMAND_LINE ((char *) (PARAM+2048))

    With this, it works for me on my PowerEdge 4600 with disks on the
    aic7xxx, and the same int13 code works on all other PowerEdge servers
    we've ever tried it on. What kind of system and disks (IDE/SCSI) and
    BIOS do you have for those please?

    > > However, changing DISKSIG_BUFFER to DISK80_SIG_BUFFER causes the kernel to
    > > reboot the computer as soon as it starts booting. Basically I select it
    > > in grub and the screen changes graphics mode and by the time it has
    > > finished the switch the computer reboots.

    Can you send me your .config and I'll try to reproduce?

    Thanks,
    Matt 

    -- 
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Martin J. Bligh: "2.6.0-test11-mjb1"

    Relevant Pages

    • Re: Proposed enhancements to MD
      ... www.snia.org in the DDF TWG section, but requires you be a member of SNIA ... Dell Linux Solutions www.dell.com/linux ... Linux on Dell mailing lists @ http://lists.us.dell.com ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: PATCH (for 2.6.3-rc1) for cdrom driver dvd_read_struct
      ... People much prefer to see a quoting style as above (date, from line, ... Dell Linux Solutions linux.dell.com & www.dell.com/linux ... Linux on Dell mailing lists @ http://lists.us.dell.com ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: intel-agp: skip non-AGP devices
      ... Dell Linux Solutions linux.dell.com & www.dell.com/linux ... Linux on Dell mailing lists @ http://lists.us.dell.com ... struct agp_bridge_data *bridge; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: aacraid hangs at boot on linux-2.4.27-pre1 20 second delay at lilo prompt makes it succeed
      ... It's possible that this is related to the firmware cache flush ... Dell Linux Solutions linux.dell.com & www.dell.com/linux ... Linux on Dell mailing lists @ http://lists.us.dell.com ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: out of memory question
      ... I have included the console output from the oom killer. ... Dell Linux Solutions linux.dell.com & www.dell.com/linux ... Linux on Dell mailing lists @ http://lists.us.dell.com ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)