Re: [linux-usb-devel] Re: [OOPS, usbcore, releaseintf] 2.6.0-test10-mm1

From: Alan Stern (stern_at_rowland.harvard.edu)
Date: 12/10/03

  • Next message: Chris Friesen: "Re: Linux GPL and binary module exception clause?" 
    Date:	Wed, 10 Dec 2003 12:25:38 -0500 (EST)
To: Greg KH <greg@kroah.com>

    Sorry Greg, I'm having trouble understanding if you're agreeing with me or
    disagreeing :-) ...

    On Wed, 10 Dec 2003, Greg KH wrote:

    > On Tue, Dec 09, 2003 at 10:43:23PM -0500, Alan Stern wrote:
    > >
    > > I looked at both the UHCI and OHCI drivers. In their module_exit routines
    > > they call pci_unregister_driver(). Without knowing how the PCI subsystem
    > > works, I would assume this behaves like any other "deregister" routine in
    > > the driver model and returns without waiting for any reference count to go
    > > to 0 -- that's what release callbacks are for.
    >
    > No, the pci core calls the release() function in the pci driver that is
    > bound to that device. It waits for that release() call to return before
    > continuing on. You can sleep for however long you want in that
    > function, but once you return from there, the pci structures for that
    > device will be cleaned up.

    I looked through the call tree for pci_unregister_driver(). There doesn't
    appear to be any place where it calls a release function. In fact, struct
    pci_driver doesn't even _contain_ a release function! Maybe you're
    thinking of the "remove" function. But pci_unregister_driver() doesn't
    wait for that; it will return immediately even if the reference count is
    still > 0.

    >
    > > However, the module_exit routines _don't_ wait for the release callbacks.
    >
    > Not true.

    Here's the entire source for the UHCI module_exit routine:

    static void __exit uhci_hcd_cleanup(void)
    {
            pci_unregister_driver(&uhci_pci_driver);
            
            if (kmem_cache_destroy(uhci_up_cachep))
                    printk(KERN_INFO "uhci: not all urb_priv's were freed\n");

    #ifdef CONFIG_PROC_FS
            remove_proc_entry("driver/uhci", 0);
    #endif

            if (errbuf)
                    kfree(errbuf);
    }

    Where in there does it wait for a release callback?

    >
    > > They just go right on ahead and exit. Result: when the reference count
    > > eventually does go to 0 (when usbfs drops its last reference), the
    > > hcd_free routine is no longer present and you get an oops.
    >
    > Hm, this could be easily tested by sleeping until usb_host_release() is
    > called when you unregister a device. The i2c, pcmcia, and network
    > subsytems do this. I think we now have a helper function in the driver
    > core to do this for us, so we don't have to declare our own completion
    > variable...

    Or sleeping until the actual release function (struct hc_driver->hcd_free)
    is called. But you have to make sure it was called for the host you are
    trying to deregister, not some other host.

    Of course, if all you want to do is unload the module then it doesn't
    matter which host is which. You just have to wait until they are all
    gone.

    Alan Stern

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Chris Friesen: "Re: Linux GPL and binary module exception clause?"

    Relevant Pages

    • Re: [linux-usb-devel] Re: [OOPS, usbcore, releaseintf] 2.6.0-test10-mm1
      ... happening in the pci code. ... Sorry, the pci driver has a removefunction, that's what I ment. ... explain the driver core... ... greg k-h ...
      (Linux-Kernel)
    • Re: Concerns about our pci_{save,restore}_state()
      ... > Hi Greg! ... I'm away from my PCI book, so I don't really know about ... We need to have a "bridge" driver for something like that. ... Hat ran into odd issues when they tried to add a pci bridge driver to ...
      (Linux-Kernel)
    • Re: Concerns about our pci_{save,restore}_state()
      ... On Thu, 2004-10-28 at 16:31 -0500, Greg KH wrote: ... I'm away from my PCI book, so I don't really know about ... Well, some cards will have side effects, whatever you write there (like ... > specific quirks needed can also just be their own driver (I think Red ...
      (Linux-Kernel)
    • Re: Is there a user space pci rescan method?
      ... > Greg KH wrote: ... > I read them and started playing around with this driver. ... Writing to that file will cause the kernel to rescan pci space, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: FPGA-pci communication
      ... I have a pci bridge ... between the pci bus and the fpga. ... I do not have driver asociated with the pci card. ... and how do I read this data on the host. ...
      (comp.arch.fpga)