[PATCH] udev-009: Allow build with empty EXTRAS

From: Adam Kropelin (akropel1_at_rochester.rr.com)
Date: 12/17/03

  • Next message: Miroslaw KLABA: "Re: Double Interrupt with HT" 
    Date:	Tue, 16 Dec 2003 22:04:06 -0500
To: greg@kroah.com

    Need to let the shell expand $EXTRAS so it can properly detect an empty
    list. Without this patch, the build fails whenever $EXTRAS is empty.

    --Adam

    --- udev-009/Makefile Tue Dec 16 19:30:32 2003
    +++ udev-009-adk/Makefile Tue Dec 16 21:47:49 2003
    @@ -145,7 +145,7 @@
     CFLAGS += -I$(PWD)/libsysfs
     
     all: $(ROOT)
    - @for target in $(EXTRAS) ; do \
    + @extras="$(EXTRAS)" ; for target in $$extras ; do \
                     echo $$target ; \
                     $(MAKE) prefix=$(prefix) LD="$(LD)" SYSFS="$(SYSFS)" \
                             -C $$target $@ ; \
    @@ -223,7 +223,7 @@
              | xargs rm -f
             -rm -f core $(ROOT) $(GEN_HEADERS) $(GEN_CONFIGS)
             $(MAKE) -C klibc clean
    - @for target in $(EXTRAS) ; do \
    + @extras="$(EXTRAS)" ; for target in $$extras ; do \
                     echo $$target ; \
                     $(MAKE) prefix=$(prefix) LD="$(LD)" SYSFS="$(SYSFS)" \
                             -C $$target $@ ; \
    @@ -286,7 +286,7 @@
             $(INSTALL_DATA) udev.permissions $(DESTDIR)$(configdir)
             - rm -f $(DESTDIR)$(hotplugdir)/udev.hotplug
             - ln -s $(sbindir)/$(ROOT) $(DESTDIR)$(hotplugdir)/udev.hotplug
    - @for target in $(EXTRAS) ; do \
    + @extras="$(EXTRAS)" ; for target in $$extras ; do \
                     echo $$target ; \
                     $(MAKE) prefix=$(prefix) LD="$(LD)" SYSFS="$(SYSFS)" \
                             -C $$target $@ ; \
    @@ -303,7 +303,7 @@
             - rmdir $(hotplugdir)
             - rmdir $(configdir)
             - rmdir $(udevdir)
    - @for target in $(EXTRAS) ; do \
    + @extras="$(EXTRAS)" ; for target in $$extras ; do \
                     echo $$target ; \
                     $(MAKE) prefix=$(prefix) LD="$(LD)" SYSFS="$(SYSFS)" \
                             -C $$target $@ ; \

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Miroslaw KLABA: "Re: Double Interrupt with HT"

    Relevant Pages