Error notification in device release

From: Alan Stern (stern_at_rowland.harvard.edu)
Date: 12/18/03

  • Next message: Sebastian Benoit: "Re: 2.6.0 keyboard not working"
    Date:	Thu, 18 Dec 2003 12:29:35 -0500 (EST)
    To: Greg KH <greg@kroah.com>
    
    

    Greg:

    Now that the driver model includes completions for release notification as
    well as release methods, the conditions for printing the warning message
    in device_release can be relaxed a little...

    Alan Stern

    ===== core.c 1.70 vs edited =====
    --- 1.70/drivers/base/core.c Fri Oct 10 16:44:38 2003
    +++ edited/drivers/base/core.c Thu Dec 18 12:19:25 2003
    @@ -80,7 +80,7 @@
     
             if (dev->release)
                     dev->release(dev);
    - else {
    + else if (!c) {
                     printk(KERN_ERR "Device '%s' does not have a release() function, "
                             "it is broken and must be fixed.\n",
                             dev->bus_id);

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Sebastian Benoit: "Re: 2.6.0 keyboard not working"

    Relevant Pages