Re: [PATCH][TRIVIAL] dep_tristate wants 3 arguments (fwd)

From: Adrian Bunk (bunk_at_fs.tum.de)
Date: 12/21/03

  • Next message: Jeff Garzik: "Re: [2.6 patch] let USB_{PEGASUS,USBNET} depend on NET_ETHERNET"
    Date:	Sun, 21 Dec 2003 03:35:45 +0100
    To: Jeff Garzik <jgarzik@pobox.com>
    
    

    On Fri, Dec 19, 2003 at 02:02:53AM -0500, Jeff Garzik wrote:
    > Adrian Bunk wrote:
    > >
    > >Consider:
    > > CONFIG_TMS380TR=m
    > >
    > >E.g. CONFIG_TMSPCI=y shouldn't be allowed in this case.
    >
    >
    > Remove the 'if' and you are correct :)

    Agreed, the updated patch is below. :-)

    > Jeff

    cu
    Adrian

    --- linux-2.4.24-pre1-full/drivers/net/tokenring/Config.in.old 2003-12-21 03:32:12.000000000 +0100
    +++ linux-2.4.24-pre1-full/drivers/net/tokenring/Config.in 2003-12-21 03:32:53.000000000 +0100
    @@ -20,12 +20,12 @@
        dep_tristate ' IBM Lanstreamer chipset PCI adapter support' CONFIG_IBMLS $CONFIG_TR $CONFIG_PCI
        dep_tristate ' 3Com 3C359 Token Link Velocity XL adapter support' CONFIG_3C359 $CONFIG_TR $CONFIG_PCI
        tristate ' Generic TMS380 Token Ring ISA/PCI adapter support' CONFIG_TMS380TR
    - if [ "$CONFIG_TMS380TR" != "n" ]; then
    - dep_tristate ' Generic TMS380 PCI support' CONFIG_TMSPCI $CONFIG_PCI
    - dep_tristate ' Generic TMS380 ISA support' CONFIG_TMSISA $CONFIG_ISA
    - dep_tristate ' Madge Smart 16/4 PCI Mk2 support' CONFIG_ABYSS $CONFIG_PCI
    - dep_tristate ' Madge Smart 16/4 Ringnode MicroChannel' CONFIG_MADGEMC $CONFIG_MCA
    - fi
    +
    + dep_tristate ' Generic TMS380 PCI support' CONFIG_TMSPCI $CONFIG_PCI $CONFIG_TMS380TR
    + dep_tristate ' Generic TMS380 ISA support' CONFIG_TMSISA $CONFIG_ISA $CONFIG_TMS380TR
    + dep_tristate ' Madge Smart 16/4 PCI Mk2 support' CONFIG_ABYSS $CONFIG_PCI $CONFIG_TMS380TR
    + dep_tristate ' Madge Smart 16/4 Ringnode MicroChannel' CONFIG_MADGEMC $CONFIG_MCA $CONFIG_TMS380TR
    +
        if [ "$CONFIG_ISA" = "y" -o "$CONFIG_MCA" = "y" ]; then
           tristate ' SMC ISA/MCA adapter support' CONFIG_SMCTR
        fi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Jeff Garzik: "Re: [2.6 patch] let USB_{PEGASUS,USBNET} depend on NET_ETHERNET"

    Relevant Pages

    • Re: 2.6.11-rc2-mm1: SuperIO scx200 breakage
      ... On Thu, 2005-01-27 at 11:20 +0100, Adrian Bunk wrote: ... >> Part of exported symbols are unexported, patch is just waiting to be sent, ... I only saw that the patch I sent two months ago still ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • RE: Error mounting root fs on 72:01 using Promise FastTrak TX2000 (PDC20271)
      ... I think the patch should be included in the official kernel ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
      (Linux-Kernel)
    • Re: 2.6.9-mm1: timer_event multiple definition
      ... On Fri, 22 Oct 2004, Adrian Bunk wrote: ... message contained a patch where the name is changed to posix_timer_event. ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • [2.6 patch] cdrom.c: make several functions static (fwd)
      ... The patch forwarded below still applies and compiles against ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ... There had been need of rain for many days. ...
      (Linux-Kernel)
    • [2.6 patch] some parport_pc.c cleanups (fwd)
      ... The patch forwarded below still applies and compiles against ... extern struct parport *parport_pc_probe_port (unsigned long base, ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)