Re: [PATCH] i2c driver fixes for 2.6.0

From: Greg KH (greg_at_kroah.com)
Date: 12/30/03

  • Next message: Greg KH: "Re: [PATCH] i2c driver fixes for 2.6.0"
    Date:	Tue, 30 Dec 2003 14:06:10 -0800
    To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
    
    

    ChangeSet 1.1496.20.1, 2003/12/17 15:44:31-08:00, khali@linux-fr.org

    [PATCH] I2C: fix i2c-amd8111 driver.

    This patch fixes i2c_smbus_write_byte() being broken for i2c-amd8111.
    This causes trouble when that module is used together with eeprom (which
    is also in 2.6). We have had no report so far, but the problem is
    similar to the one addressed by a recent patch to i2c-nforce2.

    Credits go to Hans-Frieder Vogt for finding and fixing the problem. Mark
    D. Studebaker found and fixed the original problem in i2c-nforce2.

    This is a serious bug fix, and I believe you shouldn't wait too long
    before applying it.

     drivers/i2c/busses/i2c-amd8111.c | 2 +-
     1 files changed, 1 insertion(+), 1 deletion(-)

    diff -Nru a/drivers/i2c/busses/i2c-amd8111.c b/drivers/i2c/busses/i2c-amd8111.c
    --- a/drivers/i2c/busses/i2c-amd8111.c Tue Dec 30 12:31:03 2003
    +++ b/drivers/i2c/busses/i2c-amd8111.c Tue Dec 30 12:31:03 2003
    @@ -192,7 +192,7 @@
     
                     case I2C_SMBUS_BYTE:
                             if (read_write == I2C_SMBUS_WRITE)
    - amd_ec_write(smbus, AMD_SMB_DATA, data->byte);
    + amd_ec_write(smbus, AMD_SMB_CMD, command);
                             protocol |= AMD_SMB_PRTCL_BYTE;
                             break;
     

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Greg KH: "Re: [PATCH] i2c driver fixes for 2.6.0"

    Relevant Pages

    • Re: BUG at mm/memory.c:1501 in 2.6.0-test5
      ... >Any module running inside the kernel can destroy anything. ... A simple bug in any ... You should send your report to the vendor. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.12-rc2-mm3
      ... > seems to be running Azareus. ... party PCI card, what video card are you using, can you reproduce the ... you are the only one to report that and none of the G5s here ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.15-rc1-mm2 unsusable on DELL Inspiron 8200, 2.6.15-rc1 works fine
      ... Many thanks for the report. ... Unfortunately your logging system is cutting out the most important info ... so don't worry if you can't track down the full Bad page state messages. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Badness in device_release at drivers/base/core.c:84
      ... I think this bug is due to me using the aic7xxx_old code ver 5.x.x. ... I would like to contact and report this issue to the aic7xxx maintaner ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.10-mm2
      ... does this happen and when it doesn't) and will report it by then. ... /\ attachments and Software patents. ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
      (Linux-Kernel)