Re: PATCH 1/2: Make gotoxy & siblings use unsigned variables

From: Andries Brouwer (aebr_at_win.tue.nl)
Date: 01/09/04

  • Next message: Mike Waychison: "Re: [autofs] [RFC] Towards a Modern Autofs"
    Date:	Fri, 9 Jan 2004 21:33:27 +0100
    To: Nigel Cunningham <ncunningham@users.sourceforge.net>
    
    

    >> Shouldn't we be using "size_t" for unsigned int

    > You might be right. I was just being consistent with the other definitions.

    These are character positions on a screen.
    When did you last see a console in text mode with a line length
    of more than 2^31 ?

    If you go for a minimal patch then you should replace "char"
    in one or two places by "unsigned char" and that is all.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Mike Waychison: "Re: [autofs] [RFC] Towards a Modern Autofs"

    Relevant Pages

    • Re: PATCH 1/2: Make gotoxy & siblings use unsigned variables
      ... unsigned ints as well, not because it expects 2^31 columns, but because ... > These are character positions on a screen. ... > When did you last see a console in text mode with a line length ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: VIA SATA I/O errors
      ... > and a lot of SCSI error messages will be output to the console. ... > few instances of this happening (which requires a hard power-off, ... I have no idea whether this is a software or hardware ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [RFC/PATCH-mm] i8042: activate panic blink only in X
      ... chance of keyboard still working after panic in text console. ... I'd like to have panic blink and also be able to Shft-Up to previous ... static unsigned char i8042_mux_present; ... unsigned int port_no; ...
      (Linux-Kernel)
    • Re: [linux-pm] [RFC] Add some hooks to generic suspend code
      ... > switch to other console before suspend, so X has to give up ... I'd rather not break an existing and relied upon userland interface now, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • RE: Panics need better handling
      ... It saves the panic info into a firmware log. ... Subject: Panics need better handling ... > Using a framebuffer console helps a lot. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)