Re: 2.4.23 masquerading broken?

From: Patrick McHardy (kaber_at_trash.net)
Date: 01/11/04

  • Next message: Russell King: "[PATCH] mark ide-cs broken" 
    Date:	Sun, 11 Jan 2004 11:40:37 +0100
To: Harald Welte <laforge@netfilter.org>

    Harald Welte wrote:

    >This seems to be the same as
    >http://www.ussg.iu.edu/hypermail/linux/kernel/0312.0/0465.html
    >and https://bugzilla.netfilter.org/cgi-bin/bugzilla/show_bug.cgi?id=144
    >
    >I've committed the proposed fix (from #144) into patch-o-matic/pending.
    >
    >Comments?
    >
    >

    I don't know if reverting to 2.4.22 is the correct fix, the change was made after this
    mail from Alexey http://marc.theaimsgroup.com/?l=linux-net&m=105915597804604&w=2 ,
    he states that giving out ifindex is a bug. I don't understand the problem yet but I'm
    looking into it.

    BTW: Why do we need a route lookup at all ? Couldn't we just use the first address on
    dev->in_dev->ifa_list ?

    Best regards,
    Patrick

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Russell King: "[PATCH] mark ide-cs broken"

    Relevant Pages

    • Re: Linux 2.6.15-rc5: off-line for a week
      ... Gene, in the meantime, you can fix your situation without changing any ... Linus has already applied the correct fix from Mauro ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: [2.6 patch] sound/oss/rme96xx.c: fix two check after use
      ... If there are checks, they should be there for a purpose, and any sane ... If they are dead code, ... could provide the correct fix. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] ohci1394: dma_pool_destroy while in_atomic() && irqs_disabled()
      ... Does this happen on exit or on startup? ... Looks like allocation problems, ... AFAICT the correct fix is to use ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Unregistering interfaces
      ... > I think we need to do this now, as it is not a correct fix, and causes ... that it has other problems regardless of the kobject pinning fix, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [patch] Real-Time Preemption, -RT-2.6.9-rc4-mm1-U5
      ... > The proper interface is wait_event(and variants). ... Sorry for beeing stupid. ... Correct fix appended. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)