Re: [PATCH] Add -Winline

From: Adrian Bunk (bunk_at_fs.tum.de)
Date: 01/17/04

  • Next message: George Anzinger: "Re: KGDB 2.0.3 with fixes and development in ethernet interface" 
    Date:	Sat, 17 Jan 2004 02:12:47 +0100
To: Jan Hubicka <jh@suse.cz>

    On Thu, Jan 15, 2004 at 01:55:44PM +0100, Jan Hubicka wrote:
    > > On Wed, Jan 14, 2004 at 10:07:43AM +0100, Andi Kleen wrote:
    > > >
    > > > Add -Winline by default. This makes the compiler warn when something
    > > > marked inline is not getting inlined. This is often because the
    > > >
    > > > It should only make a difference with gcc 3.4, because in earlier
    > > > compilers we use always_inline and not inlining with always_inline
    > > > is an error already.
    > > >...
    > >
    > > Attached are all inlining warnings I get with this patch applied in
    > > 2.6.1-mm3 using gcc 3.3.3 20040110 (prerelease) (Debian).
    > >
    > > I've gzip'ed it since it was > 100 kB.
    > >
    > > A few warnings might be missing since I used a .config with
    > > CONFIG_SMP=y.
    >
    > Are you sure that you do use always_inline? (ie can you look into one
    > of preprocessed file for declaration of some of failed functions?)

    Yes, e.g. in drivers/ieee1394/eth1394.c:

    <-- snip -->

    ...
    static __inline__ __attribute__((always_inline)) __attribute__((always_inline))
    void purge_partial_datagram(struct list_head *old)
    {
    ...

    <-- snip -->

    > Honza

    cu
    Adrian 

    -- 
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: George Anzinger: "Re: KGDB 2.0.3 with fixes and development in ethernet interface"

    Relevant Pages
    Loading