Re: kgdb 2.0.5

From: Pavel Machek (pavel_at_ucw.cz)
Date: 01/20/04

  • Next message: Pavel Machek: "Re: Help port swsusp to ppc." 
    Date:	Tue, 20 Jan 2004 21:35:29 +0100
To: "Amit S. Kale" <amitkale@emsyssoft.com>

    Hi!

    > kgdb 2.0.5 is available at
    > http://kgdb.sourceforge.net/kgdb-2/linux-2.6.1-kgdb-2.0.5.tar.bz2
    >
    > ChangeLog
    > 2004-01-20 Amit S. Kale <amitkale@emsyssoft.com>
    > * Created a ring buffer for kgdb ethernet packets. Several
    > fixes and changes to kgdb on ethernet.
    >
    > 2004-01-20 TimeSys Corporation
    > * Fixed a problem with not responding to Ctrl+C during priting of
    > console messages through gdb.
    >
    > I have pasted below eth.patch for review. When using the ethernet interface,
    > gdb times out several times. It receives packets and junk instead of acks. I
    > see following type of messages out of 8139too.c on the console
    > "eth0:Out-of-sync dirty pointer, 15 vs. 20."
    >
    > Any comments/suggestions/fixes on this patch are most welcome.

    Okay, so you wanted comments :-)

    @@ -2031,12 +2031,14 @@
      obj-$(CONFIG_VORTEX) += 3c59x.o
     Index: linux/drivers/net/kgdb_eth.c
     ===================================================================
    ---- linux.orig/drivers/net/kgdb_eth.c 2004-01-17 14:58:20.000000000 +0100
    -+++ linux/drivers/net/kgdb_eth.c 2004-01-17 14:58:20.000000000 +0100
    -@@ -0,0 +1,588 @@
    +--- linux.orig/drivers/net/kgdb_eth.c 2004-01-20 14:29:19.000000000 +0100
    ++++ linux/drivers/net/kgdb_eth.c 2004-01-20 14:29:19.000000000 +0100
    +@@ -0,0 +1,704 @@
     +/*
     + * Network interface GDB stub
     + *
    ++ * Copyright (C), 2004 Amit S. Kale
    ++ *
     + * Written by San Mehat (nettwerk@biodome.org)
     + * Based upon 'gdbserial' by David Grothe (dave@gcom.com)
     + * and Scott Foehner (sfoehner@engr.sgi.com)
    @@ -2045,6 +2047,8 @@
     + * and wangdi <wangdi@clusterfs.com>.
     + *
     + * Restructured for generic a gdb interface
    ++ * Reveral changes to make it free of device driver changes.
    ++ * Added internal buffers for this interface.
     + * by Amit S. Kale <amitkale@emsyssoft.com>
     + * Some cleanups by Pavel Machek <pavel@suse.cz>
     + */
    @@ -2100,9 +2104,107 @@
     +static int kgdbeth_sendbufchars;
     +static irqreturn_t (*kgdbeth_irqhandler)(int, void *, struct pt_regs *) = NULL;
     +
    -+int kgdbeth_is_trapped;
     +struct net_device *kgdb_netdevice = NULL;
     +
    ++/* Indicates dept of recursion for xmitlock hold */
    ++static int xlockholdcount = 0;

    This should be xlock_hold_count according to CodingStyle.

    ++/* Holds xmitlock of the ethernet device
    ++ * Recursive calls allowed */
    ++static void kgdbeth_holdxlock(void)
    ++{

    Why not calling it simply kgdbeth_lock()?

    ++ if (spin_is_locked(&kgdb_netdevice->xmit_lock)) {
    ++ if (kgdb_netdevice->xmit_lock_owner == smp_processor_id()) {
    ++ goto gotit;
    ++ }
    ++ }
    ++ spin_lock(&kgdb_netdevice->xmit_lock);
    ++ kgdb_netdevice->xmit_lock_owner = smp_processor_id();
    ++
    ++gotit:
    ++ xlockholdcount++;
    ++}
    ++
    ++/* releases xmitlock of the ethernet device
    ++ * Recursive calls allowed */
    ++static void kgdbeth_relxlock(void)

    kgdbeth_unlock()?

     +int
     +kgdbeth_hook(void)
     +{
    -+ char kgdb_netdev[16];
     + extern void kgdb_respond_ok(void);
     + struct irqaction *ia_ptr;
    ++ int i;
     +
    -+ sprintf(kgdb_netdev, "eth%d", kgdb_eth);
    ++ sprintf(kgdb_netdevname, "eth%d", kgdb_eth);

    kgdb_netdev_name?

    @@ -2183,11 +2283,11 @@
     + memcpy(eth->h_source, kgdb_localmac, kgdb_netdevice->addr_len);
     + memcpy(eth->h_dest, kgdb_remotemac, kgdb_netdevice->addr_len);
     +
    -+ spin_lock(&kgdb_netdevice->xmit_lock);
    -+ kgdb_netdevice->xmit_lock_owner = smp_processor_id();
     + kgdb_netdevice->hard_start_xmit(skb, kgdb_netdevice);
    -+ kgdb_netdevice->xmit_lock_owner = -1;
    -+ spin_unlock(&kgdb_netdevice->xmit_lock);
    ++ if (atomic_read(&skb->users) != 1) {
    ++ BUG();
    ++ }
    ++ kgdbeth_relxlock();
     +}
     +
     +static void kgdbeth_flush(void)

    BUG_ON(atomic_read() != 1)?

                                                                    Pavel 

    -- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Pavel Machek: "Re: Help port swsusp to ppc."

    Relevant Pages

    • Re: [linux-usb-devel] Re: Fw: Re: oops in choose_configuration()
      ... pointer, an array, and a pointer to an array, especially when following ... We start out with the first interface setting, as we always know we have ... The bMaxPower value could be different for different altsettings. ...
      (Linux-Kernel)
    • Re: Development / Debugging tools - advice needed.
      ... >, registers, stack, memory dump, and coprocessor on the ... A graphical interface (or text mode ... > It also covers up the disassembler output of GDB. ... there's the "display" command to make gdb show stuff in ...
      (comp.os.linux.development.system)
    • Re: kgdb 2.0.5
      ... When using the ethernet interface, ... ++static int bufnum; ... ++static void kgdbeth_holdxlock ...
      (Linux-Kernel)
    • Re: C++ COM object calling C# delegate callback causes crash
      ... Where the delegate is passed in a different way. ... public interface IDVBSubtitle ... public static void SetFilter{ ... With this change it actually works, the callback is now called as ...
      (microsoft.public.dotnet.framework.interop)
    • Re: Interfaces and Events
      ... That's how I originally set the interface up. ... class Lulli: IXox ... public event FooHandler Foo; ... static void Main ...
      (microsoft.public.dotnet.languages.csharp)