Re: 2.6.2-rc1-mm1

From: Greg KH (greg_at_kroah.com)
Date: 01/23/04

  • Next message: Linus Torvalds: "Re: 2.6.1-mm5 versus gcc 3.5 snapshot" 
    Date:	Thu, 22 Jan 2004 15:38:54 -0800
To: viro@parcelfarce.linux.theplanet.co.uk

    On Thu, Jan 22, 2004 at 03:19:43PM +0000, viro@parcelfarce.linux.theplanet.co.uk wrote:
    > On Thu, Jan 22, 2004 at 11:03:42AM +0000, Christoph Hellwig wrote:
    > > > sysfs-class-06-raw.patch
    > > > From: Greg KH <greg@kroah.com>
    > > > Subject: [PATCH] add sysfs class support for raw devices [06/10]
    > >
    > > This one exports get_gendisk, which is a no-go.
    >
    > Moreover, it obviously leaks references to struct gendisk _and_ changes
    > semantics of RAW_SETBIND in incompatible way.
    >
    > Consider that vetoed. And yes, get_gendisk() issue alone would be enough.

    Yes, I realize this patch isn't quite sane yet, that's why it's still in
    the -mm tree :)

    > Greg, please, RTFS to see at which point do we decide which driver will
    > be used by raw device. It's _not_ RAW_SETBIND, it's open(). So where
    > your symlink should point is undecided until the same point.

    I don't care about which driver is used by the raw device, I care about
    which block device the raw device is "bound" to. That happens at
    RAW_SETBIND time, right? We do this in the line:
            rawdev->binding = bdget(dev);

    Hm, wait, are you saying that at open() time we actually bind the char
    device to the block device, and that struct block_device can change
    between RAW_SETBIND and open() time due to hotpluggable devices?

    Or am I missing something else here?

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Linus Torvalds: "Re: 2.6.1-mm5 versus gcc 3.5 snapshot"

    Relevant Pages

    • Re: Fw: signed kernel modules?
      ... On an Intel test board. ... I did a module signing patch some years ago. ... All I say is, take care. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: WINE + NX (No eXecute) support for x86, 2.6.7-rc2-bk2
      ... if there is no standard, ... > If you don't care about binary compatability, ... At least some people out there seem to care about it. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: BK kernel workflow
      ... > That's not a network protocol, just change the bloody commit trigger. ... > I don't care if you get that information, if you want it, have at it. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Raw Disk I/O under Linux
      ... >> between normal block device and the raw device. ... nowadays you can open a block device using the O_DIRECT open ... >No problem, I can always allocate twice as much space as I need, ... alignment essentially needs to be to the sector size of the ...
      (comp.os.linux.development.system)
    • Re: Reliable CD Ejection
      ... I'm using the Solaris SUNWcdrw package to burn disks so I decided to use it to extract the raw device number using 'cdrw -l'. ... Fortunately I'm working on a closed system so I could parse out the /etc/mnttab file to get the block device for the /cdrom mount point but this would never work in a real world situation. ...
      (comp.unix.programmer)