Re: [PATCH 2.6.2-rc1-mm2] fs/xfs/xfs_log_recover.c

From: Bryan Whitehead (driver_at_jpl.nasa.gov)
Date: 01/25/04

  • Next message: Wakko Warner: "2.6.1 dual xeon" 
    Date:	Sat, 24 Jan 2004 17:10:16 -0800
To: Bryan Whitehead <driver@megahappy.net>

    If I'm off base on this then sorry for the trouble. Just thought I'd
    take a hit at getting rid of some compiler warnings..

    Bryan Whitehead wrote:
    > Oh, one more thing. After removed the superflurous switch statement flags
    > will have a value which fixes the warning.
    >
    > If you look at the flow of code it is impossible for flags to not have a
    > value when it gets to the if statement as the previous switch statement
    > would give it a value. But since that switch statement only catches that
    > one case anyway, it's better to merge the 2 switch statemnets.
    >
    > On Sat, 24 Jan 2004, Christoph Hellwig wrote:
    >
    >
    >>On Fri, Jan 23, 2004 at 11:31:11PM -0800, Bryan Whitehead wrote:
    >>
    >>>This fixes a warning on compile of the xfs fs module.
    >>
    >>This patch looks very strange. What error do you get without it?
    >>
    >
    > 

    -- 
Bryan Whitehead
Email:driver@megahappy.net
WorkE:driver@jpl.nasa.gov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Wakko Warner: "2.6.1 dual xeon"

    Relevant Pages