[patch] Re: Kernels > 2.6.1-mm3 do not boot. - SOLVED

From: Adrian Bunk (bunk_at_fs.tum.de)
Date: 01/25/04

  • Next message: Alan Stern: "Re: PATCH: (as177) Add class_device_unregister_wait() and platform_device_unregister_wait() to the driver model core" 
    Date:	Sun, 25 Jan 2004 18:30:48 +0100
To: Fabio Coatti <cova@ferrara.linux.it>, Andi Kleen <ak@muc.de>, Andrew Morton <akpm@osdl.org>

    On Sun, Jan 25, 2004 at 06:11:27PM +0100, Fabio Coatti wrote:
    > Alle Sunday 25 January 2004 17:21, Adrian Bunk ha scritto:
    >
    > >
    > > What's your gcc version ("gcc --version")?
    >
    > gcc (GCC) 3.3.1 (Mandrake Linux 9.2 3.3.1-2mdk)
    >
    >
    > >
    > > Could you back out ("patch -p1 -R < ..." or manually remove the lines)
    > > the patch below and retry?
    >
    > Yep, and now it works :)
    > Now I'm running 2.6.1-mm4, tested both UP and SMP (SMT) and it boots just
    > fine. Later I'll try with more recents releases, but I'm pretty sure that
    > these will work.
    >
    > Many thanks, the patch has solved this issue :)

    Many thanks to Eric and you for your help in tracking the problem down!

    @Andi,Andrew:

    It seems use-funit-at-a-time breaks with distributions shipping a gcc
    3.3 that supports -funit-at-a-time.

    Th patch below replaces use-funit-at-a-time.patch and uses
    scripts/gcc-version.sh from add-config-for-mregparm-3-ng* to use
    -funit-at-a-time only with gcc >= 3.4 .

    cu
    Adrian

    --- linux-2.6.2-rc1-mm3/Makefile.old 2004-01-25 18:22:25.000000000 +0100
    +++ linux-2.6.2-rc1-mm3/Makefile 2004-01-25 18:26:56.000000000 +0100
    @@ -441,6 +441,15 @@
     CFLAGS += -g
     endif
     
    +# Enable unit-at-a-time mode when possible. It shrinks the
    +# kernel considerably.
    +#
    +# Check the gcc version since -funit-at-a-time is available since gcc 3.4,
    +# but some distributions ship a gcc 3.3 patched with a broken
    +# -funit-at-a-time implementation
    +GCC_VERSION = $(shell $(CONFIG_SHELL) scripts/gcc-version.sh $(CC))
    +CFLAGS += $(shell if [ $(GCC_VERSION) -ge 0304 ] ; then echo "-funit-at-a-time"; fi ;)
    +
     # warn about C99 declaration after statement
     CFLAGS += $(call check_gcc,-Wdeclaration-after-statement,)
     

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Alan Stern: "Re: PATCH: (as177) Add class_device_unregister_wait() and platform_device_unregister_wait() to the driver model core"

    Relevant Pages

    • Re: [PATCH 12/39] NLKD/i386 - time adjustment
      ... The patch includes code that seems to imply that gcc can not do mpy of variables. ... I really do not see the relavence of the run time library patches given the above. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [CFT] updated gcc-3.4.0 fixes patch for 2.4.27-pre1
      ... I propose fixing problems that will appear with gcc 3.5, ... Here is a patch for the few places I got hit at. ... pci_set_drvdata(pci_dev, dev); ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH 1/2] new valid_signal function (fwd)
      ... A while back I attempted to fix a little, not at all critical, gcc -W ... Below is the first patch that adds the new function. ... pointless and generates warnings when building with gcc -W. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [patch] Re: Kernels > 2.6.1-mm3 do not boot. - REALLY SOLVED
      ... My version of gcc, I just sent you adding the ... >> secondary kernel, recompiled without it and all was fine again. ... This patch should fix it. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [parisc-linux] Re: [PATCH 3/9] mm: parisc pte atomicity
      ... using your own tmpalias area sounds much better than getting ... I've simply not wrapped my head around the races, ... it looks like we agree that my patch is necessary and valid as is; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)