Re: [PATCH] PnP Updates for 2.6.2-rc2

From: Adam Belay (ambx1_at_neo.rr.com)
Date: 01/30/04

  • Next message: Ulrich Drepper: "Re: [RFC][PATCH] linux-2.6.2-rc2_vsyscall-gtod_B1.patch"
    Date:	Thu, 29 Jan 2004 23:55:04 +0000
    To: Andrew Morton <akpm@osdl.org>
    
    

    The serial driver currently fails to unregister its pnp driver upon module
    unload. This patch corrects the problem by calling pnp_unregister_driver and
    implementing a proper remove function.

    --- a/drivers/serial/8250_pnp.c 2004-01-28 22:35:02.000000000 +0000
    +++ b/drivers/serial/8250_pnp.c 2004-01-28 22:33:40.000000000 +0000
    @@ -418,7 +418,9 @@

     static void serial_pnp_remove(struct pnp_dev * dev)
     {
    - return;
    + int line = (int)pnp_get_drvdata(dev);
    + if (line)
    + unregister_serial(line - 1);
     }

     static struct pnp_driver serial_pnp_driver = {
    @@ -435,7 +437,7 @@

     static void __exit serial8250_pnp_exit(void)
     {
    - /* FIXME */
    + pnp_unregister_driver(&serial_pnp_driver);
     }

     module_init(serial8250_pnp_init);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Ulrich Drepper: "Re: [RFC][PATCH] linux-2.6.2-rc2_vsyscall-gtod_B1.patch"

    Relevant Pages

    • Re: Need break driver<-->pci-device automatic association
      ... >> device from the serial driver, without having to recompile the kernel? ... > properly you need to get the relevant pci check into the serial driver ... > proper by submitting it to Russell King. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Problem with PPPD on dialup with 2.6.11-bk1 and later; 2.6.11 is OK
      ... I also found that reverting that patch made the problem go away for 2.6.11-bk1. ... The bookmarkable link for this changeset is here: ... >Some checkin since 2.6.11 has caused the serial driver to ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Linux 2.4.28-rc1
      ... Any chance of getting this in? ... Paul Fulghum ... Fix lockup caused by serial driver not clearing ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Linux 2.6.10-rc2
      ... so I do not want to see anything but bug-fixes until 2.6.10 ... There's a few more non-bugfix changes which need merging first though. ... Namely an update to the S3C2410 serial driver from Ben to allow the ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Linux 2.6.10-rc2
      ... > There's a few more non-bugfix changes which need merging first though. ... The new patch for the serial driver fixes/updates has been sent to ... so hopefully this should complete the patch set. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)