Re: [CRYPTO]: Miscompiling sha256.c by gcc 3.2.3 and arch pentium3,4
From: Andy Isaacson (adi_at_hexapodia.org)
Date: 01/30/04
- Previous message: Nakajima, Jun: "RE: [patch] PCI Express Enhanced Config Patch - 2.6.0-test11"
- In reply to: James Morris: "Re: [CRYPTO]: Miscompiling sha256.c by gcc 3.2.3 and arch pentium3,4"
- Next in thread: Jakub Jelinek: "Re: [CRYPTO]: Miscompiling sha256.c by gcc 3.2.3 and arch pentium3,4"
- Reply: Jakub Jelinek: "Re: [CRYPTO]: Miscompiling sha256.c by gcc 3.2.3 and arch pentium3,4"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Fri, 30 Jan 2004 11:14:07 -0600 To: James Morris <jmorris@redhat.com>
On Fri, Jan 30, 2004 at 11:35:20AM -0500, James Morris wrote:
> - const u8 padding[64] = { 0x80, };
> + static u8 padding[64] = { 0x80, };
The RedHat bug suggests 'static const' as the appropriate replacement.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=114610#c4
Unfortunately that probably means an extra 64 bytes of text, rather than
the 10 or so bytes of instructions to do the memset and store. Ideally
padding[] would be allocated in BSS rather than text or the stack (and
initialized with { 0x80, } at runtime), but I guess you can't have
everything.
-andy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Nakajima, Jun: "RE: [patch] PCI Express Enhanced Config Patch - 2.6.0-test11"
- In reply to: James Morris: "Re: [CRYPTO]: Miscompiling sha256.c by gcc 3.2.3 and arch pentium3,4"
- Next in thread: Jakub Jelinek: "Re: [CRYPTO]: Miscompiling sha256.c by gcc 3.2.3 and arch pentium3,4"
- Reply: Jakub Jelinek: "Re: [CRYPTO]: Miscompiling sha256.c by gcc 3.2.3 and arch pentium3,4"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
