Re: 2.6.2-rc2-mm2

From: John Stoffel (stoffel_at_lucent.com)
Date: 01/30/04

  • Next message: Thomas Davis: "Re: Linux v2.6.2-rc2"
    Date:	Fri, 30 Jan 2004 16:16:56 -0500
    To: Andrew Morton <akpm@osdl.org>
    
    

    >>>>> "Andrew" == Andrew Morton <akpm@osdl.org> writes:

    Andrew> Can we do d)?

    Andrew> static long do_setgroups(int gidsetsize, gid_t __user *user_grouplist,
    Andrew> gid_t *kern_grouplist)
    Andrew> {
    Andrew> gid_t groups[NGROUPS];

    Call me stupid, but what if we accept the patches to increase the
    number of groups, won't that make this array be huge potentially?
    Shouldn't we instead do a kmalloc() using current->ngroups instead?

    John
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Thomas Davis: "Re: Linux v2.6.2-rc2"

    Relevant Pages

    • Re: [BK] upgrade will be needed
      ... I just disagree that it was an absolute requirement or worth its cost ... Andrew uses BK too. ... He extends its function by maintaining a set of patches ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 10/13] remove aggressive idle balancing
      ... I didn't have any plans to get these in for 2.6.12 (2.6.13 at the ... But it will be nice if Andrew can pick these up ... I pretty much agree with your ealier breakdown of the patches (ie. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 10/13] remove aggressive idle balancing
      ... they are very scary and I guarantee they'll cause ... > I pretty much agree with your ealier breakdown of the patches (ie. ... Any problem with you taking these now though Andrew? ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [RFD] Explicitly documenting patch submission
      ... Andrew integrates both patches, ... But -mm is actually maintained as a serial set of patches, ... signed-off-bys might get messy. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 2.6.14-rc4] Maintainers one entry removed
      ... I've got a spinlock problem that ... has me in a bind at the moment with the patches. ... I jokingly told Andrew ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)