Re: 2.6.2-rc2 nfsd+xfs spins in i_size_read()
From: Nathan Scott (nathans_at_sgi.com)
Date: 01/31/04
- Previous message: Tom Rini: "Re: [ANNOUNCE] udev 015 release"
- In reply to: Andrew Morton: "Re: 2.6.2-rc2 nfsd+xfs spins in i_size_read()"
- Next in thread: Nathan Scott: "Re: 2.6.2-rc2 nfsd+xfs spins in i_size_read()"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Sat, 31 Jan 2004 10:07:34 +1100 To: Andrew Morton <akpm@osdl.org>
On Fri, Jan 30, 2004 at 02:34:59PM -0800, Andrew Morton wrote:
> Miquel van Smoorenburg <miquels@cistron.nl> wrote:
> > What lock exactly is supposed to protect i_size_write, since it
> > appears that i_size_write is being called without proper locking ?
> > (Am I right?)
>
> If two CPUs hit i_size_write() at the same time we have a bug. That
> function requires that the caller provide external serialisation, via i_sem.
Hmm... I suspect we may not always be providing that in XFS -
I'll go audit our calls.
> Try adding this to the start of i_size_write():
>
> if (down_trylock(&inode->i_sem) == 0) {
> printk("I am buggy\n");
> dump_stack();
> up(&inode->i_sem);
> }
Let me know what you hit Miquel :) - I'll run the XFS tests
next week with this too and see what I can find.
thanks.
-- Nathan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Tom Rini: "Re: [ANNOUNCE] udev 015 release"
- In reply to: Andrew Morton: "Re: 2.6.2-rc2 nfsd+xfs spins in i_size_read()"
- Next in thread: Nathan Scott: "Re: 2.6.2-rc2 nfsd+xfs spins in i_size_read()"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
