Re: 2.6.2-rc2 nfsd+xfs spins in i_size_read()

From: Christoph Hellwig (hch_at_infradead.org)
Date: 01/31/04

  • Next message: OGAWA Hirofumi: "Re: PATCH to access old-style FAT fs"
    Date:	Sat, 31 Jan 2004 17:07:10 +0000
    To: Miquel van Smoorenburg <miquels@cistron.nl>
    
    

    Here's an (untested) quickhack to take i_sem in linvfs_getattr.
    I'll try to come up with a real fix next week.

    --- 1.39/fs/xfs/linux/xfs_iops.c Fri Jan 9 01:07:07 2004
    +++ edited/fs/xfs/linux/xfs_iops.c Sat Jan 31 18:41:44 2004
    @@ -478,8 +478,11 @@
             vnode_t *vp = LINVFS_GET_VP(inode);
             int error = 0;
     
    - if (unlikely(vp->v_flag & VMODIFIED))
    + if (unlikely(vp->v_flag & VMODIFIED)) {
    + down(&inode->i_sem);
                     error = vn_revalidate(vp);
    + up(&inode->i_sem);
    + }
             if (!error)
                     generic_fillattr(inode, stat);
             return 0;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: OGAWA Hirofumi: "Re: PATCH to access old-style FAT fs"

    Relevant Pages

    • Re: [2.6.16rc2] compile error
      ... To unsubscribe from this list: ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ... Copyright 2006 by Maurice Eugene Heskett, ...
      (Linux-Kernel)
    • Administrivia: FAQ etc.
      ... Subject: Administrivia: FAQ etc. ... It contains information such as how to unsubscribe from the list and what ... Out of Office Autoreplies ... frustrating when you post to the list and get 50 out of office messages ...
      (Focus-Microsoft)
    • Re: [patch 0/14] s3c2412/s3c2413 support
      ... implementations. ... To unsubscribe from this list: ... Please read the FAQ at http://www.tux.org/lkml/ ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
      (Linux-Kernel)
    • Re: Suspend to RAM generates oops and general protection fault
      ... he said it looked like a CPU hotplug ... To unsubscribe from this list: ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: potential security issue
      ... Please provide me with a PGP key. ... To unsubscribe from this list: ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)