Re: The survival of ide-scsi in 2.6.x [PATCH 2/3]

From: Jens Axboe (axboe_at_suse.de)
Date: 01/31/04

  • Next message: Roland McGrath: "Re: BUG: NTPL: waitpid() doesn't return?" 
    Date:	Sat, 31 Jan 2004 22:49:03 +0100
To: Willem Riede <wrlk@riede.org>

    On Sat, Jan 31 2004, Willem Riede wrote:
    > On 2004.01.30 17:56, Bartlomiej Zolnierkiewicz wrote:
    > >
    > > Can you split your patch and drop cosmetic changes?
    >
    > Changes in this second patch:
    > - some whitespace changes to improve readability
    > - use consistent printk priorities
    >
    > Regards, Willem Riede.
    >
    > --- p1/drivers/scsi/ide-scsi.c 2004-01-31 15:37:31.000000000 -0500
    > +++ p2/drivers/scsi/ide-scsi.c 2004-01-31 15:57:08.000000000 -0500
    > @@ -54,7 +54,9 @@
    > #include "hosts.h"
    > #include <scsi/sg.h>
    >
    > -#define IDESCSI_DEBUG_LOG 0
    > +#define IDESCSI_DEBUG_LOG 0
    > +#define IDESCSI_DEBUG KERN_NOTICE
    > +#define IDESCSI_LOG KERN_INFO

    Hmm

    > @@ -309,23 +311,25 @@
    >
    > static int idescsi_end_request (ide_drive_t *drive, int uptodate, int nrsecs)
    > {
    > - idescsi_scsi_t *scsi = drive_to_idescsi(drive);
    > - struct request *rq = HWGROUP(drive)->rq;
    > - idescsi_pc_t *pc = (idescsi_pc_t *) rq->special;
    > - int log = test_bit(IDESCSI_LOG_CMD, &scsi->log);
    > + idescsi_scsi_t *scsi = drive_to_idescsi(drive);
    > + struct request *rq = HWGROUP(drive)->rq;
    > + idescsi_pc_t *pc = (idescsi_pc_t *) rq->special;
    > + int log = test_bit(IDESCSI_LOG_CMD, &scsi->log);
    > struct Scsi_Host *host;
    > - u8 *scsi_buf;
    > - unsigned long flags;
    > + u8 *scsi_buf;
    > + unsigned long flags;

    What is the point of this? Forget any (bogus) white space and style
    "cleanups", it's totally irrelevant. Produce the patches fixing some
    issues, cleanups are really not appropriate.

    I hope your 3rd patch will be just that. Make sure it patch against
    vanilla tree, not the two just sent. 

    -- 
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Roland McGrath: "Re: BUG: NTPL: waitpid() doesn't return?"

    Relevant Pages

    • [2.6 patch] SCSI NCR53C9x.c: some cleanups (fwd)
      ... The patch forwarded below still applies and compiles against ... The patch below contains some cleanups. ... extern int esp_abort; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH] cifs: whitespace cleanups for fcntl.c
      ... Here's a patch with cleanups for fs/cifs/fcntl.c ... This time the file is so small and the cleanups so trivial that I chose to ... +int cifs_dir_notify ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [2.6 patch] net/seeq8005.c: small cleanups (fwd)
      ... The trivial patch forwarded below still applies and compiles against ... The patch below does the following small cleanups in seeq8005.c: ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • [2.6 patch] drivers/ide/: possible cleanups
      ... This patch contains the following possible cleanups: ... make a needlessly global function static ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [2.6 patch] sound/: possible cleanups
      ... This patch contains the following possible cleanups: ... +static void snd_generic_device_release(struct device *dev) ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)