[patch] 2.4.25-rc1: amd7930_fn doesn't compile

From: Adrian Bunk (bunk_at_fs.tum.de)
Date: 02/06/04

  • Next message: Michael Buesch: "Re: psmouse.c, throwing 3 bytes away"
    Date:	Fri, 6 Feb 2004 19:01:44 +0100
    To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>, info@formula-n.de, kronos@kronoz.cjb.net
    
    

    On Thu, Feb 05, 2004 at 10:44:31AM -0200, Marcelo Tosatti wrote:
    >...
    > Summary of changes from v2.4.25-pre8 to v2.4.25-rc1
    > ============================================
    >...
    > Luca Tettamanti:
    >...
    > o Fix amd7930_fn.h compilation warning
    >...

    This causes the following compile error when trying to compile this
    driver statically into a kernel with CONFIG_HOTPLUG=n :

    <-- snip -->

    ...
    gcc -D__KERNEL__
    -I/home/bunk/linux/kernel-2.4/linux-2.4.25-rc1-full-no-hotplug/include
    -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
    -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2
    -march=athlon -DHISAX_MAX_CARDS=8 -nostdinc -iwithprefix include
    -DKBUILD_BASENAME=amd7930_fn -c -o amd7930_fn.o amd7930_fn.c
    amd7930_fn.c: In function `Amd7930_init':
    amd7930_fn.c:752: error: Amd7930_init causes a section type conflict
    {standard input}: Assembler messages:
    {standard input}:2: Warning: setting incorrect section attributes for .text.init
    make[4]: *** [amd7930_fn.o] Error 1
    make[4]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.25-rc1-full-no-hotplug/drivers/isdn/hisax'

    <-- snip -->

    The fix is obvious:

    --- linux-2.4.25-rc1-full-no-hotplug/drivers/isdn/hisax/amd7930_fn.c.old 2004-02-06 00:37:28.000000000 +0100
    +++ linux-2.4.25-rc1-full-no-hotplug/drivers/isdn/hisax/amd7930_fn.c 2004-02-06 00:37:56.000000000 +0100
    @@ -61,7 +61,7 @@
     #include <linux/interrupt.h>
     #include <linux/init.h>
     
    -static WORD initAMD[] __devinit = {
    +static WORD initAMD[] __devinitdata = {
             0x0100,
     
             0x00A5, 3, 0x01, 0x40, 0x58, // LPR, LMR1, LMR2

    cu
    Adrian

    -- 
           "Is there not promise of rain?" Ling Tan asked suddenly out
            of the darkness. There had been need of rain for many days.
           "Only a promise," Lao Er said.
                                           Pearl S. Buck - Dragon Seed
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Michael Buesch: "Re: psmouse.c, throwing 3 bytes away"

    Relevant Pages

    • Re: Actual Lottery Stuff. WOW eh?
      ... (Clue #1) ... I never bother to compile any project because I almost always ... I put a comment into it that tells how to fix it, ... VB5 was a major upgrade from all previous versions in that it compiles ...
      (rec.gambling.lottery)
    • Re: pointer q
      ... If you were trying to fix the code further up so it would compile what you wanted was: ... More a case of only reading part of the data with my "fix". ... Am I not reading, with correction, the number that a smaller type thinks a larger type was? ... It may have looked formatted on your machine, but here it looks a right mess, and I'm not going to try all my fonts on the off chance one uses the same spacings as whatever font you used. ...
      (comp.lang.c)
    • where are the sources :-)
      ... I can't wait to get the sources and compile for test (currently using ... >Alan started doing forward-porting of 2.4.x driver updates, ... >and USB updates. ... > o fix all the paths in ide Kconfig docs ...
      (Linux-Kernel)
    • Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS
      ... >> Is it my fault that you applied neither Al Viro's patches to remove the ... > That won't make powerpc compile. ... And it's my job to fix every single such bug before you'd accept ... on all architectures. ...
      (Linux-Kernel)
    • Re: [patch 07/45] v4l/dvb: Fix CI on old KNC1 DVBC cards
      ... I only saw it when trying to compile kernel 2.6.17.7. ... Edgar Hucek ... This fix does not compile on 2.6.17.7. ... Currently I am doing lots of refactoring work in the dvb tree. ...
      (Linux-Kernel)