Re: [PATCH 406] Amiga Zorro8390 Ethernet new driver model

From: Adrian Bunk (bunk_at_fs.tum.de)
Date: 02/08/04

  • Next message: Fab Tillier: "RE: [Infiniband-general] Getting an Infiniband access layer in theLinux kernel"
    Date:	Sun, 8 Feb 2004 17:46:38 +0100
    To: Geert Uytterhoeven <geert@linux-m68k.org>
    
    

    On Sun, Feb 08, 2004 at 04:28:30PM +0100, Geert Uytterhoeven wrote:
    > Zorro8390 Ethernet: Convert to the new driver model
    >
    > --- linux-2.6.3-rc1/drivers/net/zorro8390.c 2004-02-08 10:19:44.000000000 +0100
    > +++ linux-m68k-2.6.3-rc1/drivers/net/zorro8390.c 2004-02-08 11:42:34.000000000 +0100
    >...
    > -static int __init zorro8390_probe(void);
    > +static int __devinit zorro8390_init_one(struct zorro_dev *z,
    > + const struct zorro_device_id *ent);
    > static int __init zorro8390_init(struct net_device *dev, unsigned long board,
    > const char *name, unsigned long ioaddr);
    >...
    > -static int __init zorro8390_probe(void)
    > +static int __devinit zorro8390_init_one(struct zorro_dev *z,
    > + const struct zorro_device_id *ent)
    > {
    >...
    > + if ((err = zorro8390_init(dev, board, cards[i].name,
    > + ZTWO_VADDR(ioaddr)))) {
    > + release_mem_region(ioaddr, NE_IO_EXTENT*2);
    > + free_netdev(dev);
    > + return err;
    > + }
    > + zorro_set_drvdata(z, dev);
    > + return 0;
    > }
    >...

    __init zorro8390_init called from __devinit zorro8390_init_one ?

    This will break when compiling the driver statically into a kernel with
    CONFIG_HOTPLUG=y .

    > Gr{oetje,eeting}s,
    >
    > Geert

    cu
    Adrian

    -- 
           "Is there not promise of rain?" Ling Tan asked suddenly out
            of the darkness. There had been need of rain for many days.
           "Only a promise," Lao Er said.
                                           Pearl S. Buck - Dragon Seed
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Fab Tillier: "RE: [Infiniband-general] Getting an Infiniband access layer in theLinux kernel"

    Relevant Pages

    • Re: Bloat report 2.6.3 -> 2.6.4
      ... For the average computer you can buy at your supermarket today it isn't ... People who need to care about the size of the kernel use hand-tuned ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: ANNOUNCE: CE Linux Forum - Specification V1.0 draft
      ... Kernel SHALL be configuralble with compiler size options, ... "specification" didn't send a patch - the trivial patch was sent by ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Weirdness with suspending jobs in 2.6.9-rc3
      ... >> It doesn't depend on which version I'm compiling, ... >> kernel I'm actually running. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [Ocfs2-devel] Re: [RFC] [PATCH] OCFS2
      ... > It's a generic mechanism for userspace driven configuration of kernel ... > subsystems/projects could use it too, ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] add a config option for -Os compilation
      ... kernel with some supported compilers) ... there might be fast path code somewhere in the kernel that becomes ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)