Re: Linux 2.6.3-rc4

From: Adrian Bunk (bunk_at_fs.tum.de)
Date: 02/17/04

  • Next message: Martin Hicks: "Re: [PATCH] Reduce TLB flushing during process migration" 
    Date:	Tue, 17 Feb 2004 21:05:46 +0100
To: Linus Torvalds <torvalds@osdl.org>, zippel@linux-m68k.org, Benjamin Herrenschmidt <benh@kernel.crashing.org>

    On Tue, Feb 17, 2004 at 11:09:45AM -0800, Linus Torvalds wrote:
    >
    >
    > On Tue, 17 Feb 2004, GCS wrote:
    > >
    > > drivers/built-in.o(.text+0xb2c44): In function `radeon_do_probe_i2c_edid':
    > > : undefined reference to `i2c_transfer'
    > > make: *** [.tmp_vmlinux1] Error 1
    > >
    > > .config snippshet:
    > > # CONFIG_FB_RADEON_OLD is not set
    > > CONFIG_FB_RADEON=y
    > > CONFIG_FB_RADEON_I2C=y
    > > CONFIG_FB_RADEON_DEBUG=y
    >
    > I don't see this. What's your I2C config, and how did you generate your
    > config file?
    >
    > CONFIG_FB_RADEON_I2C should depend on CONFIG_I2C, and it selects
    > I2C_ALGOBIT, but your error messages seem to imply that you don't have i2c
    > enabled at all.
    >
    > Which implies a configuration error (but the Kconfig file looks correct,
    > so I wonder if you found a bug in the configurator).

    Most likely the problem is CONFIG_I2C=m and the fact that FB_RADEON_I2C
    is a bool.

    I don't know whether there's a better way to express this, but something
    like the following is required:

    --- linux-2.6.3-rc4/drivers/video/Kconfig.old 2004-02-17 21:00:24.000000000 +0100
    +++ linux-2.6.3-rc4/drivers/video/Kconfig 2004-02-17 21:01:53.000000000 +0100
    @@ -644,7 +644,7 @@
     
     config FB_RADEON_I2C
             bool "DDC/I2C for ATI Radeon support"
    - depends on FB_RADEON && I2C
    + depends on (FB_RADEON=m && I2C) || (FB_RADEON=y && I2C=y)
             select I2C_ALGOBIT
             default y
             help

    > Linus

    cu
    Adrian 

    -- 
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Martin Hicks: "Re: [PATCH] Reduce TLB flushing during process migration"

    Relevant Pages

    • Re: [BUG] linux-next: Tree for May 19/20/21 - BUG at arch/x86/kernel/io_apic_64.c:353!
      ... Can you include the config when you send these, ... from next report will send across the .config file also. ... for the kernel bug discussed. ... # PCI IDE chipsets support ...
      (Linux-Kernel)
    • Re: [2.6 patch] ISDN_CAPI_CAPIFS related cleanups
      ... >> This patch contains the following cleanups: ... >> config ISDN_CAPI_CAPIFS_BOOL ... There had been need of rain for many days. ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: [bk patches] Long delayed input update
      ... >> Stop messing with peoples minds. ... The default config should contain ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: libata-dev queue updated
      ... > config SCSI_SATA ... this bug reintroduces a problem with SCSI=m. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • 2.6.0-test4: CONFIG_KCORE_AOUT doesnt compile
      ... > .config included ... Executable file formats ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)