Re: [BUG] unsafe reset in ac97_codec.c
From: Liam Girdwood (liam.girdwood_at_wolfsonmicro.com)
Date: 02/26/04
- Previous message: Kristian Soerensen: "Re: Implement new system call in 2.6"
- In reply to: Alan Cox: "Re: [BUG] unsafe reset in ac97_codec.c"
- Next in thread: Jeff Garzik: "Re: [BUG] unsafe reset in ac97_codec.c"
- Reply: Jeff Garzik: "Re: [BUG] unsafe reset in ac97_codec.c"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
To: Alan Cox <alan@lxorguk.ukuu.org.uk> Date: Thu, 26 Feb 2004 15:55:34 +0000
Hi
I've attached a patch against 2.4.25 that now checks for the codec type
before doing the AC97 register reset.
Changes:-
o Added AC97_DEFAULT_POWER_OFF to ac97_codec_ids[]
o ac97_probe now checks hardwired codec ID's before sending a reset
o Added initial support for WM9713 AC97 codec.
Liam
On Thu, 2004-02-05 at 17:59, Alan Cox wrote:
> On Iau, 2004-02-05 at 16:31, Liam Girdwood wrote:
> > I agree, but I think we need to be aware of the codec type before we do
> > a register reset. This type of codec is now becoming popular in PDA's.
>
> Sometimes we can't even find out but yes I agree
>
> > I can see another problem with the current probe implementation.
> > Currently it sends the register reset command without first checking the
> > codec ready bit. This assumes that the AC97 link is up and completely
> > working before probe is called.
>
> It is (in theory) the job of the calling driver to ensure AC97 is up
> before doing the reset part.
>
> > I'll implement this if it's acceptable as I can test it on both types of
> > codec.
>
> Sounds right to me
>
>
> ________________________________________________________________________
> This email has been scanned for all viruses by the MessageLabs Email
> Security System.
> ________________________________________________________________________
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- application/x-gzip attachment: ac_power.diff.gz
- Previous message: Kristian Soerensen: "Re: Implement new system call in 2.6"
- In reply to: Alan Cox: "Re: [BUG] unsafe reset in ac97_codec.c"
- Next in thread: Jeff Garzik: "Re: [BUG] unsafe reset in ac97_codec.c"
- Reply: Jeff Garzik: "Re: [BUG] unsafe reset in ac97_codec.c"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
